Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed ban new button issue #9670

Merged
merged 4 commits into from
Jul 20, 2024

Conversation

darshanvss
Copy link
Contributor

Banned competitors page bugs #9652

  • Moved 'No Data to show' logic into BannedCompetitors.jsx
  • Moved the 'Ban new competitor' button to top of list
  • Added new boolean prop to have only one 'Ban new Competitor' button

@darshanvss
Copy link
Contributor Author

The formatting is being changed when I am saving files as I am using prettier. How do I avoid this so it would be easier to see the actual changes?

Copy link
Member

@danieljames-dj danieljames-dj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @darshanvss for taking the initiative to work on this.

I've left some comments. Also, regarding prettier, I would suggest to disable it for this project. The reason is that different people can have different prettier configurations and we don't have a prettierrc in our code to make it unique.

I personally use eslint for formatting because eslint will use the configs in eslintrc.json of our repository and hence there won't be any conflicts from existing codebase.

@danieljames-dj
Copy link
Member

@darshanvss Can you also please fix the "TrailingWhitespace" error that is thrown?

@darshanvss
Copy link
Contributor Author

Hi @danieljames-dj I have removed the whitespace 👍

@gregorbg gregorbg merged commit 7ab4272 into thewca:main Jul 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants