Handle leading/trailing spaces in search input

[maxidragon]

It's very annoying when you paste a competition name that accidentally has a space before the actual name, causing the search to fail. The same issue occurs if there are, for example, two spaces between words.

After these changes, it's no longer possible to start a search with a space or type multiple consecutive spaces. I couldn't find a better solution to this, if anyone has suggestions feel free to comment on this PR.

[jonatanklosko]

We could only change the value send in the request, but I would actually move this all the way up and make the server decide. It would be here:

wca-live/lib/wca_live/competitions.ex

Lines 39 to 41 in 5f546f5

	defp filter_by_text(query, filter) do
	from c in query, where: ilike(c.name, ^"%#{filter}%")
	end

You can add

filter = filter |> String.trim() |> String.replace(~r/\s+/, " ")

and then we can expand this test:

wca-live/test/wca_live/competitions_test.exs

Lines 21 to 31 in 5f546f5

	test "list_competitions/1 given :filter returns competitions with matching name" do
	worlds = insert(:competition, name: "World Championship 2020")
	open = insert(:competition, name: "WHAT Open 2020")
	euro = insert(:competition, name: "Euro Championship 2020")
	list = Competitions.list_competitions(%{filter: "champion"})
	assert worlds.id in ids(list)
	assert open.id not in ids(list)
	assert euro.id in ids(list)
	end

[maxidragon]

That would be nice, but I've tried trimming the name on the backend (and changing the value only for the request), and it won't actually work because the Autocomplete component does its own filtering, regardless of what is in the array.

[jonatanklosko]

We can skip the default Autocomplete filtering, by adding this:

filterOptions={(options, state) => options}

[maxidragon]

We can skip the default Autocomplete filtering, by adding this:

filterOptions={(options, state) => options}

This is exactly what I was looking for but couldn’t find, thanks!

[jonatanklosko]

Thanks!