Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add John Kjell as TAP Editor #303

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Conversation

jkjell
Copy link
Contributor

@jkjell jkjell commented Mar 25, 2024

Based on the interest for additional TAP Editors and the conversations at KubeCon EU, I'd like to submit my name for consideration.

@JustinCappos
Copy link
Member

Big +1 here!

JustinCappos
JustinCappos previously approved these changes Mar 25, 2024
joshuagl
joshuagl previously approved these changes Mar 26, 2024
Copy link
Member

@joshuagl joshuagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 welcome to the team, John

Could you update the patch so that editors are sorted alphabetically by last name? 🙏

mnm678
mnm678 previously approved these changes Mar 26, 2024
Copy link
Collaborator

@mnm678 mnm678 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 welcome!

@jkjell jkjell dismissed stale reviews from mnm678, joshuagl, and JustinCappos via 0ae1027 March 26, 2024 13:38
@JustinCappos JustinCappos merged commit 258ad50 into theupdateframework:master Mar 26, 2024
1 check passed
@mnm678
Copy link
Collaborator

mnm678 commented Mar 27, 2024

@JustinCappos or @joshuagl should have the org-level permissions to update the GitHub team

@joshuagl
Copy link
Member

I just sent the invite to @jkjell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants