Sanitize repo simulator role names when writing

[MVrachev]

Description of the changes being introduced by the pull request:

Sanitize the role names in the repo simulator when dumping in a
directory the same way the ngclient does.
That's necessary because when testing fishy role names from test_updater_with_simulator leads to an
error:
PermissionError: [Errno 13] Permission denied: '/.json'

Please verify and check that the pull request fulfills the following
requirements:

• The code follows the Code Style Guidelines
• Tests have been added for the bug fix or new feature
• Docs have been added for the bug fix or new feature

[coveralls]

Pull Request Test Coverage Report for Build 1527420364

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+1.0%) to 98.579%

---

Totals
Change from base Build 1520084662:	1.0%
Covered Lines:	3869
Relevant Lines:	3895

---

💛 - Coveralls

[jku]

alternatively could sanitize the delegated rolename when writing the file like client does (quoted_role = parse.quote(role, ""))

[sechkova]

Well it just happened that I did the same thing yesterday: dc908ee
(without the part in test_updater_with_simulator.py)

[MVrachev]

Well it just happened that I did the same thing yesterday: dc908ee
(without the part in test_updater_with_simulator.py)

@sechkova I am sorry it happened that way, I haven't read #1689 and didn't notice that.
I will drop this commit and leave only the commit related to the error.

[sechkova]

Bad timing on both sides 🤷 Can you have a look at my commit before dropping yours? Maybe I've missed something.

[MVrachev]

Bad timing on both sides 🤷 Can you have a look at my commit before dropping yours? Maybe I've missed something.

I just had a look and yours seems to cover what I did here, so don't worry.

[MVrachev]

I updated the code by using what @jku suggested.
Additionally, the commit and pr descriptions were changed together with the pr title.

[jku]

This commit does not do what the message says.

• It url encodes role names that do not need sanitizing (but does not url encode the delegated role names that could need it)
• Then it skips dumping metadata for roles that actually would need sanitizing if they were used as filenames?

[MVrachev]

This commit does not do what the message says.

• It url encodes role names that do not need sanitizing (but does not url encode the delegated role names that could need it)
• Then it skips dumping metadata for roles that actually would need sanitizing if they were used as filenames?

I changed the code to dump the delegated roles and removed the code where I skipped dumping.