Start to keep Architectural Decision Records (ADRs) for tuf reference implementation#1182
Merged
lukpueh merged 4 commits intotheupdateframework:developfrom Oct 27, 2020
Merged
Conversation
joshuagl
force-pushed
the
joshuagl/adrs
branch
from
6a67cda to
ffe75f2
Compare
Member
Author
Member
Member
Author
I think you're right! We did remove |
MVrachev
approved these changes
Oct 22, 2020
mnm678
approved these changes
Oct 22, 2020
Contributor
mnm678
left a comment
mnm678
left a comment
There was a problem hiding this comment.
These look great. Once the AppVeyor issue is resolved I think it's good to go.
In order to make decisions about the code and the design explicit and easier to reference in future we want to record significant architectural decisions. This commit introduces docs/adr with a template Architectural Decision Record and index using the [MADR](https://adr.github.io/madr/) format. It also adds ADR 0000 to document the decisions to use MADR. Fixes theupdateframework#1141 Signed-off-by: Joshua Lock <jlock@vmware.com>
Signed-off-by: Joshua Lock <jlock@vmware.com>
Document the decision drop support for EOL Python versions, most notable Python 2.7 Fixes theupdateframework#1125 Signed-off-by: Joshua Lock <jlock@vmware.com>
joshuagl
force-pushed
the
joshuagl/adrs
branch
from
ffe75f2 to
71de3f6
Compare
Provide additional context to clarify where we expect Python 3.6+ to be used exclusively (new modules) and link to other discussions around the future of Python 2.7 supporting code. Signed-off-by: Joshua Lock <jlock@vmware.com>
lukpueh
approved these changes
Oct 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1141, #1125
Description of the changes being introduced by the pull request:
Add initial Architectural Decision Records (ADRs) documenting some workflow decisions before the refactor:
Please verify and check that the pull request fulfills the following
requirements: