Skip to content

Remove sof logging ctx #8725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove sof logging ctx #8725

wants to merge 1 commit into from

Conversation

@btian1
Copy link
Contributor

@btian1 btian1 commented Jan 11, 2024

No description provided.

lgirdwood
lgirdwood reviewed Jan 11, 2024
View reviewed changes
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@btian1 for changes like this is best to show before and after in the logs as part of your commit message so everyone can follow.

@btian1
Copy link
Contributor Author

btian1 commented Jan 15, 2024

@dbaluta @iuliana-prodan , could you help check from IPC3 side? as this change only have impact on IPC3 and I don't have a way to check.

@dbaluta
Copy link
Collaborator

dbaluta commented Jan 15, 2024

Will try to have a look this week.

@btian1
Copy link
Contributor Author

btian1 commented Jan 19, 2024

Will try to have a look this week.

Any progress? @dbaluta , this DRAFT patch try to remove each module's ctx dependency for further one logging interface.
And since ctx is only used by IPC3 logging, request help from you here for double confirm, if it is acceptable:

  1. All DECLARE_TR_CTX will be removed.
  2. Zephyr and non-zephyr logging will have same logging interface.

@dbaluta
Copy link
Collaborator

dbaluta commented Jan 25, 2024

@btian1 tested this on imx8mp. Logging works fine after your patch.

@btian1 btian1 mentioned this pull request Jan 31, 2024
Closed
@btian1
Trace: remove trace ctx and uuid assignment for logs
9c259ff 
Test patch, will check ipc3 and ipc4 logs still correct or not,
if still correct, means these part can be deleted from current
logging, it is a preparation for align sof logging with zephyr
logging.

Signed-off-by: Baofeng Tian <[email protected]>
@lgirdwood
Copy link
Member

lgirdwood commented Feb 23, 2024

@btian1 draft ?

@dbaluta
Copy link
Collaborator

dbaluta commented Feb 23, 2024

If i remember correctly this is only for testing purposes.

@btian1 btian1 closed this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbaluta dbaluta dbaluta approved these changes

@lgirdwood lgirdwood lgirdwood approved these changes

@iuliana-prodan iuliana-prodan Awaiting requested review from iuliana-prodan

@akloniex akloniex Awaiting requested review from akloniex akloniex will be requested when the pull request is marked ready for review akloniex is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@btian1 @dbaluta @lgirdwood