-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pipeline: allow render pipeline to recover from xrun #125
pipeline: allow render pipeline to recover from xrun #125
Conversation
Fixes pipeline's ability to recover from xrun for render streams. Normally for render the ppl task is scheduled after trigger start, but in this case trigger start is done on current's task level. Signed-off-by: Tomasz Lauda <[email protected]>
I was about to merge when you closed, I guess you have a better fix ? |
Probably, just hold on a little bit longer. |
You can merge it as it is. |
@@ -1090,6 +1106,17 @@ static int pipeline_xrun_recover(struct pipeline *p) | |||
return ret; | |||
} | |||
|
|||
/* for playback copy it here, because scheduling won't work | |||
* on this interrupt level | |||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So you mean you kept the schedule idle copy in the pipeline trigger start as it will never work there?
Thus this is some workaround for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly. Also my comment is a little bit misleading. To be precised, schedule won't work, because scheduler doesn't allow to add to the list tasks, which are currently running.
…flow logger: string overflow warning fix
Fixes pipeline's ability to recover from xrun for render streams.
Normally for render the ppl task is scheduled after trigger start,
but in this case trigger start is done on current's task level.
Signed-off-by: Tomasz Lauda [email protected]