Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Xrun recovery inside FW. #710

Closed
keyonjie opened this issue Dec 13, 2018 · 7 comments
Closed

Remove Xrun recovery inside FW. #710

keyonjie opened this issue Dec 13, 2018 · 7 comments
Assignees
Labels
enhancement New feature or request P2 Critical bugs or normal features

Comments

@keyonjie
Copy link
Contributor

keyonjie commented Dec 13, 2018

SOF FW will need to remove recovery trying code, e.g. pipeline_prepare(), trigger start, and schedule copy.

Just keep sending Xrun IPC to host driver side, host framework(e.g. ALSA) will help to handle this recovery if possible, e.g. trigger stop and start.

@mengdonglin mengdonglin added the enhancement New feature or request label Dec 13, 2018
@lgirdwood
Copy link
Member

ok, no objections from me but we need to make sure drivers does do the recovery.

@keyonjie
Copy link
Contributor Author

@lgirdwood sure, @bardliao is working on that.

@bardliao
Copy link
Collaborator

@keyonjie @lgirdwood My plan is to return SNDRV_PCM_POS_XRUN in sof_pcm_pointer when kernel receive the XRUN message from FW.

@lgirdwood
Copy link
Member

@mmaka1 any comment on your preference here about who recovers XRUN ?

@slawblauciak
Copy link
Collaborator

FW xrun recovery will be disabled once driver fully handles the situation
thesofproject/linux#660

@jajanusz
Copy link
Contributor

jajanusz commented Jun 6, 2019

WIP #1439

@jajanusz jajanusz added the P2 Critical bugs or normal features label Jun 6, 2019
@tlauda
Copy link
Contributor

tlauda commented Oct 25, 2019

It's disabled in FW.

@tlauda tlauda closed this as completed Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 Critical bugs or normal features
Projects
None yet
Development

No branches or pull requests

7 participants