Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xrun handling should be handled by alsa instead of firmware #660

Closed
slawblauciak opened this issue Feb 18, 2019 · 6 comments
Closed

xrun handling should be handled by alsa instead of firmware #660

slawblauciak opened this issue Feb 18, 2019 · 6 comments
Assignees
Labels
enhancement New feature or request P1 Blocker bugs or important features

Comments

@slawblauciak
Copy link

Currently the driver assumes the xrun will be handled by the firmware.
Ultimately it should be handled by alsa itself by simply restarting the stream, since firmware isn't capable of resetting DMA pointers.

@mengdonglin
Copy link
Collaborator

thesofproject/sof#851 is to add support for ALSA xrun recovery in firmware side and also needs a kernel config DEBUG_XRUN_STOP=y

@mengdonglin mengdonglin added the P1 Blocker bugs or important features label Feb 18, 2019
@plbossart
Copy link
Member

@slawblauciak What you describe is the standard ALSA xrun handling, not sure what is needed in the SOF-specific parts?

@wenqingfu
Copy link

are we done with this topic? @keyonjie

@keyonjie
Copy link

@wenqingfu I think so, to move to ALSA Xrun handling, we should define NO_XRUN_RECOVERY in FW and select CONFIG_SND_SOC_SOF_DEBUG_XRUN_STOP in driver(or add this to FW_READY struct later), but as we haven't defined NO_XRUN_RECOVERY in FW yet, so QA haven't verified this.

So in short sentence, let's say we still have half day's work(add it to FW_READY and remove CONFIG_SND_SOC_SOF_DEBUG_XRUN_STOP item in kernel) remained for developing.

@plbossart
Copy link
Member

@slawblauciak @keyonjie can we close this, it's been stale for 8 months now?

@keyonjie
Copy link

keyonjie commented Jan 9, 2020

@plbossart I think so, as we already set NO_XRUN_RECOVERY in FW by default, and in driver CONFIG_SND_SOC_SOF_DEBUG_XRUN_STOP is not selected by default. Let me close it.

@keyonjie keyonjie closed this as completed Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P1 Blocker bugs or important features
Projects
None yet
Development

No branches or pull requests

5 participants