upstream reviews - take 2 #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plbossart
requested review from
ranj063,
bardliao,
keyonjie,
lgirdwood and
RanderWang
RanderWang
approved these changes
Nov 30, 2018
bardliao
requested changes
Nov 30, 2018
keyonjie
reviewed
Nov 30, 2018
plbossart
force-pushed
the
fix/upstream-reviews2
branch
from
cbdc405
to
80bb3e0
Compare
|
@RanderWang we can do whatever changes we want to sof structures since we 'own' the framework. Modifying or abusing ALSA or ASoC APIs and structures is not ok in general, we are not the owners and need to have a strong case to get a change accepted by Mark Brown and Takashi Iwai. |
Make it clear that the current solution is not acceptable and has to be reworked Signed-off-by: Pierre-Louis Bossart <[email protected]>
It is not clear why the parsing should continue, so for now exit and return an error. This is only used by BYT/CHT/BDW anyways so the odd of new features being added are slim. Signed-off-by: Pierre-Louis Bossart <[email protected]>
The error flow in pcm_new was completely broken, make sure the page tables are released. The pre-allocated DMA buffer is not released since it's a task the ALSA core will do for us. Added comment of the intent so that people looking for balanced memory allocations understand this is not an omission. Signed-off-by: Pierre-Louis Bossart <[email protected]>
plbossart
force-pushed
the
fix/upstream-reviews2
branch
from
80bb3e0
to
9374795
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
comments on the link DMA support to indicate the current solution is not quite final.
Also fix two issues detected during code reviews (36 patches!), we had 2 issues with error flows for the code loader and the PCM handling. @bardliao you may want to check if the PCM part impacts the load/unload work you are doing.
An additional issue was fixed already by Seppo in a separate PR.