ASoC: SOF: ignore unrecoverable CTX_SAVE IPC errors at suspend #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plbossart
reviewed
Jun 3, 2019
As part of the suspend flow, a context save IPC message is sent to the firmware before powering down the DSP. If errors are met, the suspend flow is aborted with current code. Change the behaviour such that if firmware returns -EBUSY or -EAGAIN, return the error codes to PM core as before. The device is left in active state in this case. If other errors are reported, print a warning but do not block the suspend flow. As per interface specification, no valid error can be returned in this scenario. If the hardware has hit a fatal error and is not able to respond successfully, best recovery method is to proceed with suspend and power off the DSP. Signed-off-by: Kai Vehmanen <[email protected]>
kv2019i
force-pushed
the
topic/ignore-fatal-ctxsave-error-at-suspend
branch
from
1aff0eb
to
a2748c6
Compare
ranj063
approved these changes
Jun 5, 2019
lgirdwood
approved these changes
Jun 5, 2019
|
@kv2019i some conflicts |
What do you mean @lgirdwood ? I was about to merge but not sure if you've saying to hold off for now? |
|
no info from @lgirdwood so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Harden SOF against unexpected DSP errors by ignoring unknown errors of CTX_SAVE at suspend.
Without this, any issue with DSP results in a situation where system reboot is needed. To err on the side of precaution, suspend should proceed by default.
Note: this patch was earlier part of wdog RFC series (PR841), but is now submitted independently for merging as it seems to bring value on its own based on experiences from IPC timeout bughunt in 2019 May.