Advanced invite flow #307
Open
Advanced invite flow #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Notes This adds a new feature to the `/create-invite` flow which prompts the inviter to select 3 main questions: 1. Is this a Thesis employee or contractor? 2. Which discipline(s) will this person be working with? 3. Which project(s) will this person be working with? After those interactions are complete, an invite is generated with 7 days expiry and 1 use to the channel with `project-discipline` matching. Still WIP ### To-do
This is still not working as intended, just some exploratory code on getting role assignment to work for project + discpline cases rather than audit channels. Based off invite counter this one is not so clear cut. Also we must have invite uses always be greater than 1, or else invite count gets wiped as soon as member join, preventing us from checking which invite code was used.
Seems like those 🔒 emojis need to be removed in order to get correct role mapping, working as it should.
This commit resolves an issue where the old invites were not loading properly, now will be stored on runtime and the list updated anytime the invite command is run, so we can store it in cache before invite is claimed.
Get working with base role assignment if on questions you select "no"
|
@Shadowfiend Added an update here with the contractor flow. For now if you hit No on the first "Is this a Thesis employee or contractor?", we generate an invite with Thesis base role. For determining the secondary question "What channels should they have access to?" We have to decide if we want to follow rolemapping for additional roles that follow channel name i.e |
This commit swaps things around to resolve a bug happening when invite codes are not stored, this now makes sure the invite codes are stored when creating a new invite, so uses can be counted forwards.
|
Calling this one ready for review, although just need to remove the loggers since there are quite a few of them for testing :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
This adds a new feature to the
/create-inviteflow which prompts the inviter to select 3 main questions:After those interactions are complete, an invite is generated with 7 days expiry and 2 uses (in-order to count invites on join) to the channel with
project-disciplinematching.Still WIP
Screenshots
To-do