dApp: Wallet connection info alert #917
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for acre-dapp-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for acre-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dapp/src/components/shared/Alert.tsx
Outdated
| @@ -22,7 +22,7 @@ import Spinner from "./Spinner" | |||
| const STATUSES = { | |||
| info: { | |||
| icon: IconInfoCircle, | |||
| colorScheme: "gold", | |||
| colorScheme: "blue", | |||
There was a problem hiding this comment.
This change affects all alerts in the dApp. We probably don't want that but it should be confirmed with Sorin. We should probably set colorScheme when we define CONNECTION_ALERTS. This solution seems the easiest until we have a styleguide.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: AENG-24
This pull request focuses on refactoring the wallet connection error handling system to use alerts of multiple types. The changes include renaming components and contexts, updating imports and hooks, and modifying the structure of connection alerts.
Changes:
statusfromWalletConnectionAlertContext: Storingstatusin context is redundant. It was always"error"and having it in context made it difficult to control. Thestatusproperty has only presentational purpose so it should be adjustable at the component level.Alertcomponent styling: Change title font weight and removed margin.Modalcomponent styling to match designs: Update paddings to match designsBefore:
After: