Update `cd` command to use correct path traversal from the `path` crate to allow for parent directory #1104

nnh12 · 2024-08-28T17:27:32Z

This pull request adds the option to navigate to the parent directory respective of the current working directory, without specifying the full path. The cd .. is a standard operation in linux. For example, if current directory is /extra_files/test_files, running cd .. moves directory to /extra_files.

Below are some test cases ran on Theseus:

/extra_files/test_files: cd ..
task[20] existed with code 0 (0x0)
/extra_files:

/extra_files: cd ..
task [21] exited with code 0 (0x0)
/:

/extra_files/test_files/text: cd ..
task[28] exited with code 0 (0x0)
/extra_files/test_files:

The default cd operation still works too:

/extra_files/test_files/: cd text
task[29] exited with code 0 (0x0)
/extra_files/test_files/text:

Add changes to call correct path using get API in the path crate.

kevinaboos

Thanks, looks great now!

…ee7688f

Nathan Hsiao added 14 commits August 28, 2024 11:16

Initial parent directory command

e185ac3

Remove '-p' argument in place with '..'

bd1b82f

Clean up syntax

2d6cfcb

Update parent flag in print usage option

d7307bf

Remove verbose print statement

2d6eeda

Remove unnecessary space

e94fa9e

Attempt to move parent directory logic to kernel

df05211

Remove unnecessary Path crate and copy of working directory

6aff644

Remove extra line

9e10ed5

Synatx

e316ed1

fix line

46faeb5

Call get function from path crate to add correctory directory

eb682f4

Merge branch 'nathan/parent' into nathan/cd

f9ea294

Add changes to call correct path using get API in the path crate.

Remove redundant harded parent directory check

531c847

nnh12 changed the title ~~Add cd .. option to allow user to switch to parent directory~~ Update cd command to use correct path traversal from the path crate to allow for .. Sep 6, 2024

nnh12 changed the title ~~Update cd command to use correct path traversal from the path crate to allow for ..~~ Update cd command to use correct path traversal from the path crate to allow for parent directory Sep 6, 2024

Nathan Hsiao added 2 commits September 6, 2024 16:19

Replace redundant function:

e06c19b

Remove extra line

dbdcf06

kevinaboos approved these changes Sep 9, 2024

View reviewed changes

kevinaboos merged commit ee7688f into theseus-os:theseus_main Sep 9, 2024
3 checks passed

github-actions bot pushed a commit that referenced this pull request Sep 9, 2024

Use Path::get() in chdir function to support .. path nav (#1104) …

46de335

…ee7688f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update `cd` command to use correct path traversal from the `path` crate to allow for parent directory #1104

Update `cd` command to use correct path traversal from the `path` crate to allow for parent directory #1104

nnh12 commented Aug 28, 2024 •

edited

Loading

kevinaboos left a comment

Update cd command to use correct path traversal from the path crate to allow for parent directory #1104

Update cd command to use correct path traversal from the path crate to allow for parent directory #1104

Conversation

nnh12 commented Aug 28, 2024 • edited Loading

kevinaboos left a comment

Choose a reason for hiding this comment

Update `cd` command to use correct path traversal from the `path` crate to allow for parent directory #1104

Update `cd` command to use correct path traversal from the `path` crate to allow for parent directory #1104

nnh12 commented Aug 28, 2024 •

edited

Loading