checksum: add further comments on existing fallback logic for RIPEMD/…

…WHIRLPOOL Bug: python/cpython#91257 Bug: python/cpython#92876 Bug: https://bugs.gentoo.org/846389 Signed-off-by: Sam James <[email protected]>
thesamesam · Mar 20, 2023 · ce1b224 · ce1b224
1 parent a126a6c
commit ce1b224
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/lib/portage/checksum.py b/lib/portage/checksum.py
@@ -99,10 +99,15 @@ def checksum_file(self, filename):
 # Define hash functions, try to use the best module available. Preferred
 # modules should go first, latter ones should check if the hashes aren't
 # already defined.
-
-
 # Use hashlib if available and prefer it over pycrypto and internal fallbacks.
+#
 # Need special handling for RMD160/WHIRLPOOL as they may not always be provided by hashlib.
+# We keep fallbacks for RMD160/WHIRLPOOL for now as newer OpenSSLs don't expose them
+# by default.
+# See also
+# - https://github.com/python/cpython/issues/91257
+# - https://github.com/python/cpython/issues/92876
+# - https://bugs.gentoo.org/846389
 _generate_hash_function("MD5", hashlib.md5, origin="hashlib")
 _generate_hash_function("SHA1", hashlib.sha1, origin="hashlib")
 _generate_hash_function("SHA256", hashlib.sha256, origin="hashlib")