Support old-style basket for Sage integration #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added getUseOldBasketFormat and setUseOldBasketFormat for "useOldBasketFormat" parameter in the DirectGateway class
Added a conditional statement to check which version of basket to send (Basket (old) or BasketXML (newer))
Used if old format of Basket field needs to bent with the request
Old basket format merge back to master
Added information about BasketXML & Basket fields
Contributor
|
Can you please confirm that this works in production and then I will tag for release. |
Contributor
Author
|
@delatbabel - yes, it's been working in production for some time now. |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #55. Allows you to optionally pass a parameter to force the driver to use the old-style basket format. Currently this is the only format supported by various Sage products such as Line 50, and so is preferable for merchants wishing to automate the import of SagePay transactions into Sage.