More flexible use of transactionReference with Purchase #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobvH
reviewed
Feb 20, 2018
| @@ -72,7 +72,8 @@ class PurchaseRequest extends AuthorizeRequest | |||
|
|
|||
| public function getData() | |||
| { | |||
| if ($this->parameters->get('transactionReference')) { | |||
| $realCardExists = ($this->getCard() || $this->getCardReference()); | |||
| if ($this->parameters->get('transactionReference') && !$realCardExists) { | |||
There was a problem hiding this comment.
@lukeholder simple enough. I'm curious how the expectation here failed.
The original condition is meant to differentiate between a case of a reference sale or card sale. According to this change, checking for card data is needed to truly make that determination. Seems odd, so I'm curious what you're using the transaction reference field for in a card sale...
In all other cases throughout the API (eg. voiding, etc) transaction reference === the ORIGID. Can you show me what you're doing with this field? I'm thinking it shouldn't be there, but I'd like to know if it has a valid use case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21