fix: Fix the command GenerateKeyPair #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
oharzallah-greenbull
commented
Sep 3, 2024
oharzallah-greenbull
commented
- Fix a typo in service decalaration
- Make algorithm as an argument because it was missing in the service definition and cannot be declared
|
hi @chalasr! can anyone check this PR please |
chalasr
reviewed
Sep 24, 2024
|
Do i have to change anything for the CI to work ? |
|
Nope, I'll take care of that given it's not related to your changes. Expect this to be merged next week. |
chalasr
force-pushed
the
fix/command-generate-key-pair-errors
branch
from
0a7d340 to
9dfe896
Compare
|
Thank you @oharzallah-greenbull. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.