Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Symfony 6.2 deprecation for Security helper #129

Merged
merged 1 commit into from
Apr 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 32 additions & 19 deletions src/EventListener/AuthorizationRequestUserResolvingListener.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,30 +4,43 @@

namespace League\Bundle\OAuth2ServerBundle\EventListener;

use League\Bundle\OAuth2ServerBundle\Event\AuthorizationRequestResolveEvent;
use Symfony\Component\Security\Core\Security;
use Symfony\Component\Security\Core\User\UserInterface;

/**
* Listener sets currently authenticated user to authorization request context
*/
final class AuthorizationRequestUserResolvingListener
{
use Symfony\Bundle\Security\Core\Security;
use Symfony\Component\Security\Core\Security as LegacySecurity;

if (class_exists(Security::class)) {
/**
* @var Security
* Listener sets currently authenticated user to authorization request context
*/
private $security;

public function __construct(Security $security)
final class AuthorizationRequestUserResolvingListener
{
$this->security = $security;
}
use AuthorizationRequestUserResolvingListenerTrait;

public function onAuthorizationRequest(AuthorizationRequestResolveEvent $event): void
/**
* @var Security
*/
private $security;

public function __construct(Security $security)
{
$this->security = $security;
}
}
} else {
/**
* Listener sets currently authenticated user to authorization request context
*/
final class AuthorizationRequestUserResolvingListener
{
$user = $this->security->getUser();
if ($user instanceof UserInterface) {
$event->setUser($user);
use AuthorizationRequestUserResolvingListenerTrait;

/**
* @var LegacySecurity
*/
private $security;

public function __construct(LegacySecurity $security)
{
$this->security = $security;
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<?php

namespace League\Bundle\OAuth2ServerBundle\EventListener;

use League\Bundle\OAuth2ServerBundle\Event\AuthorizationRequestResolveEvent;
use Symfony\Component\Security\Core\User\UserInterface;

trait AuthorizationRequestUserResolvingListenerTrait
{
public function onAuthorizationRequest(AuthorizationRequestResolveEvent $event): void
{
$user = $this->security->getUser();
if ($user instanceof UserInterface) {
$event->setUser($user);
}
}
}
3 changes: 1 addition & 2 deletions src/Resources/config/services.php
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
use Symfony\Component\EventDispatcher\EventDispatcherInterface;
use Symfony\Component\HttpFoundation\RequestStack;
use Symfony\Component\Security\Core\Security;

return static function (ContainerConfigurator $container): void {
$container->services()
Expand Down Expand Up @@ -208,7 +207,7 @@
// Authorization listeners
->set('league.oauth2_server.listener.authorization_request_user_resolving', AuthorizationRequestUserResolvingListener::class)
->args([
service(Security::class),
service('security.helper'),
])
->tag('kernel.event_listener', [
'event' => OAuth2Events::AUTHORIZATION_REQUEST_RESOLVE,
Expand Down