[Travis] Test on PHP 7.1 #574
Conversation
Ensures compatibility with PHP 7.1. Refs #574
|
Looks like RandomLib 1.1 has some issues with PHP 7.1 that are fixed in version 1.2. I've created #575 to address this. |
Ensures compatibility with PHP 7.1. Refs #574
|
Please rebase this branch to master so that the tests run again. |
|
Done 👍 |
|
Looks like there are still errors when mcrypt is enabled, as per ircmaxell/RandomLib#55. Needs to be fixed upstream. |
|
@shadowhand FWIW due to PHP 7.1, in the Bolt project we've decided to replace RandomLib with polyfills for PHP 5.x as a result of the breakage/noise coming from this change, and Scott seems pretty determined to get the mcrypt stuff out a.s.a.p. The hard(er) part for this project is the BC due to getter/setters in the abstract class, but thought it worth mentioning. |
|
Honestly, I think this good impetus for starting a version |
|
@shadowhand: No objections from us, but we (and a lot of projects) do need to support SF 2.8 (and 3.x from Q2/Q3 2017), which locks us at 5.5.9 for the foreseeable future. So if needed, please see a ✋ raised from me if you eventually need someone to help maintaining/backporting to whatever the legacy branch becomes. |
|
What's the status of this PR? Is more development being done to attempt to fix the failures on 7.1, or should I close this for now? |
|
@ramsey it should stay open. I will have time to dig in further this week. |
|
I'm going to address this by starting a 3.x branch that makes a few changes:
This will bring our dependencies up to latest releases and give us a solid base for starting a 4.x branch that drops PHP 5.x support. |
|
@shadowhand could we request that PHP 5.5.9 be the base PHP version for 3.x instead? As those of us producing products based on Symfony have that as a requirement. At the end of the day, I don't think it would be too a huge pain for us, but it is often hard to explain upstream decisions to people and have them not respond with "Why don't you just use something else?" |
|
@GawainLynch what would be the purpose of that? PHP 5.5 is EOL and no longer receiving patches. If you're locked into PHP 5.5, you can continue to use the 2.x series. The 3.x series will not change functionality, it will simply drop RandomLib for |
|
@shadowhand Supporting Symfony stack though to 4's release … but yeah, if it isn't good for you, no great stress. Just figured it couldn't hurt to ask, as RandomLib + PHP 7.1 is kinda painful for us right now too, we're in the position where we can extract it from Bolt's core use, but for our OAuth use-case it might still bite us, TBH haven't looked that hard yet as, well, RandomLib. 😆 |
Why to start with a 3.x branch and not with 2.x? |
|
I understand, but the last version is 1.4.2 (what I assume is calling the 1.x branch). Why do you want to skip the 2.x branch? Am I missing something? |
|
Oops, for whatever reason I thought we were on 2.x already. Thanks for pointing that out! |
|
You're welcome 😄 |
RandomLib depends on mcrypt, which is deprecated in PHP 7.1. The new random functions that are present in PHP 7 are more than sufficient for our needs and a compat package is available for PHP 5.x. Refs #574
RandomLib depends on mcrypt, which is deprecated in PHP 7.1. The new random functions that are present in PHP 7 are more than sufficient for our needs and a compat package is available for PHP 5.x. Refs #574
RandomLib depends on mcrypt, which is deprecated in PHP 7.1. The new random functions that are present in PHP 7 are more than sufficient for our needs and a compat package is available for PHP 5.x. Also enables testing on PHP 7.1. Refs #574
|
Fixed by #583. |
No description provided.