Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AVIF #333

Merged
merged 3 commits into from
Oct 26, 2021
Merged

Add support for AVIF #333

merged 3 commits into from
Oct 26, 2021

Conversation

gijsdev
Copy link
Contributor

@gijsdev gijsdev commented Oct 12, 2021

This PR adds support for the AVIF image format.
Intervention/Image added support for AVIF for the Imagick driver in 2.6.0 (Intervention/image#1056) and for the GD driver in 2.7.0 (Intervention/image#1113).

@gijsdev
Copy link
Contributor Author

gijsdev commented Oct 13, 2021

If this PR gets accepted, should I create a separate PR for Glide 1.x? Or is Glide 1.x in maintenance only mode?

@ADmad
Copy link
Collaborator

ADmad commented Oct 16, 2021

Please rebase your branch on to upstream master. I updated the GA workflow to run the tests on PHP 8.1 since AVIF support is only available from PHP 8.1.

@ADmad
Copy link
Collaborator

ADmad commented Oct 16, 2021

Or is Glide 1.x in maintenance only mode?

It's in maintenance only mode.

@gijsdev
Copy link
Contributor Author

gijsdev commented Oct 18, 2021

Done 👌

@ADmad
Copy link
Collaborator

ADmad commented Oct 19, 2021

LGTM.

@tgalopin Do you have any feedback?

@ADmad ADmad merged commit 8f62b10 into thephpleague:master Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants