Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import as-needed without implicitly importing UIKit #89

Merged
merged 9 commits into from
Nov 26, 2023

Conversation

L1ghtmann
Copy link
Member

What does this implement/fix? Explain your changes.

See title

Checklist

  • New code follows the code rules
  • I've added modulemaps for any new libraries (e.g. see libactivator/module.modulemap): it should be possible to @import MyLibrary; in ObjC, or import MyLibrary in Swift.
  • My contribution is code written by myself from reverse-engineered headers, licensed into the Public Domain as per LICENSE.md; or, code written by myself / taken from an existing project, released under an OSI-approved license, and I've added relevant licensing credit to LICENSE.md

Does this close any currently open issues?

Any relevant logs, error output, etc?

Any other comments?

Where has this been tested?

Operating System:

Linux & OSX GitHub-hosted runners

Platform:

Target Platform:

Toolchain Version:

SDK Version:

@leptos-null
Copy link
Member

Thank you for opening this PR. These changes are one of the last to bring this entire repo up to matching the code rules.
These changes also bring the CI duration from 11 minutes to 5 minutes.

Copy link
Member

@leptos-null leptos-null left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Approving on the pre-condition that the associated checks pass

@L1ghtmann L1ghtmann merged commit 1c33d11 into theos:master Nov 26, 2023
@L1ghtmann L1ghtmann deleted the imports branch November 26, 2023 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants