Conversation
Added definitions for the new GPT-5 Pro model, including pricing, provider details, and capabilities.
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
WalkthroughAdds a new OpenAI model configuration entry with id Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/models/src/models/openai.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx}: This is a pure TypeScript project—do not useanyoras anyunless absolutely necessary
Always use top-level ES imports; never userequireor dynamicimport()
Files:
packages/models/src/models/openai.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
Always use top-level import; never use require() or dynamic import()
Files:
packages/models/src/models/openai.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: e2e-shards (4)
- GitHub Check: e2e-shards (5)
- GitHub Check: e2e-shards (2)
- GitHub Check: e2e-shards (1)
- GitHub Check: test / run
- GitHub Check: generate / run
- GitHub Check: build / run
- GitHub Check: lint / run
- GitHub Check: autofix
🔇 Additional comments (2)
packages/models/src/models/openai.ts (2)
577-593: Verify whether a second provider should be added.Other GPT-5 family models (gpt-5, gpt-5-mini, gpt-5-nano) have two providers: "openai" and "routeway-discount". This model only has one provider. Please confirm whether this is intentional or if the "routeway-discount" provider should be added for consistency.
If a second provider should be added, refer to the pattern used in gpt-5 (lines 397-421) for the structure.
571-595: Validate GPT-5 Pro pricing and capacity
- Pricing matches official API: $15 / 1M input, $120 / 1M output
- ContextSize 400 000 and maxOutput 272 000 tokens aren’t documented publicly—please confirm in the official model spec docs.
Removed the 'test' property from the OpenAI provider configuration.
|
superseded by #1154 |
Added definitions for the new GPT-5 Pro model, including pricing, provider details, and capabilities.
Summary by CodeRabbit
New Features
Chores