Skip to content

feat(models): add GPT-5 Pro model definition - #994

Closed
steebchen wants to merge 3 commits into
mainfrom
feat/modelsgpt5
Closed

steebchen wants to merge 3 commits into
mainfrom
feat/modelsgpt5

Conversation

@steebchen

@steebchen steebchen commented Oct 6, 2025

Copy link
Copy Markdown
Member

Added definitions for the new GPT-5 Pro model, including pricing, provider details, and capabilities.

Summary by CodeRabbit

  • New Features

    • Added a new “GPT‑5 Pro” model option with larger context and extended max output, streaming, advanced reasoning, vision input, tool use, and structured JSON responses.
    • Appears alongside existing models in selection menus where available.
  • Chores

    • Updated model catalog and defaults, including pricing metadata for the new option.

Added definitions for the new GPT-5 Pro model, including pricing, provider details, and capabilities.
@bunnyshell

bunnyshell Bot commented Oct 6, 2025

Copy link
Copy Markdown

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@coderabbitai

coderabbitai Bot commented Oct 6, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

Adds a new OpenAI model configuration entry with id gpt-5-pro to openaiModels, specifying provider, pricing, large context/output limits, and capability flags (streaming, reasoning, vision, tools, JSON output). No exported API signatures changed; the new provider lacks a test field.

Changes

Cohort / File(s) Summary of changes
OpenAI models config
packages/models/src/models/openai.ts
Added new model entry gpt-5-pro with provider { providerId: "openai", modelName: "gpt-5-pro" }, pricing (inputPrice: 15/1e6, outputPrice: 120/1e6, requestPrice: 0), contextSize: 400000, maxOutput: 272000, and capability flags: streaming: true, reasoning: true (reasoningOutput: "omit"), vision: true, tools: true, jsonOutput: true. No test field included.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "feat(models): add GPT-5 Pro model definition" directly and accurately describes the main change in the changeset. The title clearly indicates that a new GPT-5 Pro model definition is being added to the models module, which aligns with both the file-level changes (adding a new model entry to openaiModels) and the stated PR objectives. The title is concise, specific, and avoids vague terminology, making it immediately clear to a reviewer what the primary purpose of the change is.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/modelsgpt5

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f01324a and 318d642.

📒 Files selected for processing (1)
  • packages/models/src/models/openai.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/models/src/models/openai.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
  • GitHub Check: e2e-shards (4)
  • GitHub Check: e2e-shards (2)
  • GitHub Check: e2e-shards (3)
  • GitHub Check: e2e-shards (1)
  • GitHub Check: autofix
  • GitHub Check: test / run
  • GitHub Check: build / run
  • GitHub Check: lint / run
  • GitHub Check: generate / run

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 99a0145 and f01324a.

📒 Files selected for processing (1)
  • packages/models/src/models/openai.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.{ts,tsx}: This is a pure TypeScript project—do not use any or as any unless absolutely necessary
Always use top-level ES imports; never use require or dynamic import()

Files:

  • packages/models/src/models/openai.ts
**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (AGENTS.md)

Always use top-level import; never use require() or dynamic import()

Files:

  • packages/models/src/models/openai.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
  • GitHub Check: e2e-shards (4)
  • GitHub Check: e2e-shards (5)
  • GitHub Check: e2e-shards (2)
  • GitHub Check: e2e-shards (1)
  • GitHub Check: test / run
  • GitHub Check: generate / run
  • GitHub Check: build / run
  • GitHub Check: lint / run
  • GitHub Check: autofix
🔇 Additional comments (2)
packages/models/src/models/openai.ts (2)

577-593: Verify whether a second provider should be added.

Other GPT-5 family models (gpt-5, gpt-5-mini, gpt-5-nano) have two providers: "openai" and "routeway-discount". This model only has one provider. Please confirm whether this is intentional or if the "routeway-discount" provider should be added for consistency.

If a second provider should be added, refer to the pattern used in gpt-5 (lines 397-421) for the structure.


571-595: Validate GPT-5 Pro pricing and capacity

  • Pricing matches official API: $15 / 1M input, $120 / 1M output
  • ContextSize 400 000 and maxOutput 272 000 tokens aren’t documented publicly—please confirm in the official model spec docs.

Comment thread packages/models/src/models/openai.ts
Comment thread packages/models/src/models/openai.ts Outdated
Removed the 'test' property from the OpenAI provider configuration.
@steebchen

Copy link
Copy Markdown
Member Author

superseded by #1154

@steebchen steebchen closed this Nov 15, 2025
@steebchen
steebchen deleted the feat/modelsgpt5 branch November 15, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant