Skip to content

feat(google): add deactivation dates and vision support - #954

Merged
steebchen merged 1 commit into
mainfrom
feat/google
Sep 27, 2025
Merged

steebchen merged 1 commit into
mainfrom
feat/google

Conversation

@steebchen

@steebchen steebchen commented Sep 27, 2025

Copy link
Copy Markdown
Member

Updated deactivation dates for Gemini 1.5 models and enabled vision support for "Gemini 1.5 Pro" in Google models. Expanded build script to include the "playground" application.

Summary by CodeRabbit

  • New Features

    • Enabled vision capabilities for Gemini 1.5 Pro, Gemini 1.5 Flash, and Gemini 1.5 Flash 8B, allowing image-based inputs where supported.
  • Chores

    • Scheduled deactivation for Gemini 1.5 Pro, Gemini 1.5 Flash, and Gemini 1.5 Flash 8B effective 2025-09-20; plan transitions accordingly.
    • Updated build process to include Playground in split-image builds, improving parallelization and deployment consistency across apps.

Updated deactivation dates for Gemini 1.5 models and enabled vision
support for "Gemini 1.5 Pro" in Google models. Expanded build script
to include the "playground" application.
@bunnyshell

bunnyshell Bot commented Sep 27, 2025

Copy link
Copy Markdown

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@coderabbitai

coderabbitai Bot commented Sep 27, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

Updated Google Gemini 1.5 model entries in models catalog to set concrete deactivation dates and enable vision; expanded Docker image build script to include the playground app in split builds. No control-flow or API surface changes.

Changes

Cohort / File(s) Summary of Changes
Google model metadata updates
packages/models/src/models/google.ts
Set deactivatedAt to new Date("2025-09-20") for Gemini 1.5 Pro, Flash, and Flash 8B (including repeated variants); flipped vision from false to true for these entries. No other logic or exports changed.
Build script targets
scripts/build-images.sh
Added "playground" to SPLIT_APPS array: ("api" "gateway" "playground" "ui" "docs"). No other build logic modified.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title “feat(google): add deactivation dates and vision support” clearly and concisely describes the primary change to the Google models—namely adding concrete deactivation dates and enabling vision flags—without introducing noise or irrelevant details. It follows a conventional commit style, is specific to the main functionality modified, and remains succinct.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/google

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 348e614 and 074bcab.

📒 Files selected for processing (2)
  • packages/models/src/models/google.ts (5 hunks)
  • scripts/build-images.sh (2 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.{ts,tsx}: Never use any or as any in this TypeScript project unless absolutely necessary
Always use top-level import; never use require or dynamic import()

Files:

  • packages/models/src/models/google.ts
{apps,packages}/**/src/**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (AGENTS.md)

Always use top-level import; never use require() or dynamic import()

Files:

  • packages/models/src/models/google.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
  • GitHub Check: lint / run
  • GitHub Check: build / run
  • GitHub Check: test / run
  • GitHub Check: generate / run
  • GitHub Check: autofix
  • GitHub Check: e2e-shards (2)
  • GitHub Check: e2e-shards (3)
  • GitHub Check: e2e-shards (5)
  • GitHub Check: e2e-shards (4)
  • GitHub Check: e2e-shards (1)
🔇 Additional comments (1)
scripts/build-images.sh (1)

16-16: No action needed: playground stage exists The infra/split.dockerfile defines FROM runtime AS playground at line 157, so the new playground entry in SPLIT_APPS is valid.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@steebchen
steebchen added this pull request to the merge queue Sep 27, 2025
Merged via the queue into main with commit 3b2c8fe Sep 27, 2025
15 checks passed
@steebchen
steebchen deleted the feat/google branch September 27, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant