Skip to content

revert(chore/infra): revert content collections stuff - #877

Merged
steebchen merged 2 commits into
mainfrom
chore/revert
Sep 17, 2025
Merged

steebchen merged 2 commits into
mainfrom
chore/revert

Conversation

@steebchen

@steebchen steebchen commented Sep 17, 2025

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Refactor
    • Streamlined metadata generation across several pages by removing redundant type annotations; no user-facing behavior changes.
  • Chores
    • Updated CI to run PR checks when build configuration changes.
    • Improved build caching by declaring an additional global dependency.
  • Style
    • Minor formatting cleanups with no functional impact.
  • Developer Experience
    • Added type definitions for blog and changelog content to improve editor autocomplete and consistency.

@coderabbitai

coderabbitai Bot commented Sep 17, 2025

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

Walkthrough

Adds a PR trigger for tsup files in GitHub Actions, updates Turbo global dependencies, introduces a new content-collections TypeScript declaration module, and standardizes Next.js generateMetadata typings across several pages, including a ts-ignore for category processing in one page.

Changes

Cohort / File(s) Summary
Workflow trigger update
.github/workflows/images.yml
Adds "**/tsup.ts" to on.pull_request.paths; whitespace-only formatting in some job conditions; no logic change.
Next.js metadata typing cleanup
apps/docs/app/(home)/[[...slug]]/page.tsx, apps/ui/src/app/blog/category/[category]/page.tsx, apps/ui/src/app/models/[name]/page.tsx, apps/ui/src/app/providers/[id]/page.tsx
Removes explicit Metadata imports and Promise return types from generateMetadata; relies on inference. In category page, adds TODO and // @ts-ignore before category iteration. No runtime logic changes.
Content collections declarations
apps/ui/src/types/content-collections.d.ts
Adds declaration module "content-collections" with interfaces Changelog and Blog; exports allChangelogs and allBlogs arrays.
Turbo cache dependencies
turbo.json
Adds "tsup.config.ts" to globalDependencies.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • smakosh
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/revert

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e894ab8 and 57f35fb.

📒 Files selected for processing (7)
  • .github/workflows/images.yml (3 hunks)
  • apps/docs/app/(home)/[[...slug]]/page.tsx (1 hunks)
  • apps/ui/src/app/blog/category/[category]/page.tsx (1 hunks)
  • apps/ui/src/app/models/[name]/page.tsx (1 hunks)
  • apps/ui/src/app/providers/[id]/page.tsx (1 hunks)
  • apps/ui/src/types/content-collections.d.ts (1 hunks)
  • turbo.json (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@steebchen
steebchen enabled auto-merge September 17, 2025 16:00
@steebchen
steebchen added this pull request to the merge queue Sep 17, 2025
Merged via the queue into main with commit bd0931b Sep 17, 2025
16 of 17 checks passed
@steebchen
steebchen deleted the chore/revert branch September 17, 2025 16:04
steebchen added a commit that referenced this pull request Sep 17, 2025
github-merge-queue Bot pushed a commit that referenced this pull request Sep 17, 2025
Reverts #877

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- New Features
- Category pages now show decoded titles and descriptions based on the
selected category.

- Bug Fixes
- Blog category pages are now fully pre-generated so category links
resolve correctly.

- Refactor
- Improved type safety for page metadata across docs, models, providers,
and category pages.

- Chores
  - Updated CI workflow filters and cleaned workflow formatting.
- Reduced unnecessary workspace rebuilds by relaxing a global build
dependency.
- Reordered app build script to run the site build before type checking.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant