Skip to content

feat(api): enhance reasoning content checks #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steebchen merged 3 commits into from
Sep 14, 2025
Merged

feat(api): enhance reasoning content checks #813

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bb7e650
feat(api): enhance reasoning content checks
steebchen Sep 14, 2025
f6095e1
feat(api): simplify reasoning content checks logic
steebchen Sep 14, 2025
af84186
fix(api): correct conditional logic for reasoning checks
steebchen Sep 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions apps/gateway/src/api.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,9 +625,13 @@ describe("e2e", () => {
// check for reasoning response - only if the provider expects reasoning output
const reasoningProvider = providers?.find(
(p: ProviderModelMapping) => p.reasoning === true,
);
) as ProviderModelMapping;
const useResponsesApi = process.env.USE_RESPONSES_API === "true";
const isOpenAI = reasoningProvider?.providerId === "openai";
// only enforce reasoning_content checks for where reasoningOutput is not "omit" and for openai, only if the responses api is used
if (
(reasoningProvider as ProviderModelMapping)?.reasoningOutput !== "omit"
reasoningProvider?.reasoningOutput !== "omit" &&
(!isOpenAI || useResponsesApi)
) {
expect(json.choices[0].message).toHaveProperty("reasoning_content");
}
Expand Down Expand Up @@ -736,9 +740,13 @@ describe("e2e", () => {
// Verify reasoning content is present in unified reasoning_content field - only if the provider expects reasoning output
const reasoningProvider = providers?.find(
(p: ProviderModelMapping) => p.reasoning === true,
);
) as ProviderModelMapping;
const useResponsesApi = process.env.USE_RESPONSES_API === "true";
const isOpenAI = reasoningProvider?.providerId === "openai";
// When using the Responses API, only enforce reasoning_content checks for OpenAI.
if (
(reasoningProvider as ProviderModelMapping)?.reasoningOutput !== "omit"
reasoningProvider?.reasoningOutput !== "omit" &&
(!isOpenAI || useResponsesApi)
) {
const reasoningChunks = streamResult.chunks.filter(
(chunk: any) =>
Expand Down
Loading