Repository navigation
fix(chat): tool calls fixes & e2e tests #675
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -369,9 +369,25 @@ export async function prepareRequestBody( | |
| case "openai": { | ||
| if (supportsReasoning) { | ||
| // Transform to responses API format (now supports tools as well) | ||
| // Clean messages by removing tool_calls and tool_call_id fields | ||
| // Also transform 'tool' role to 'user' role since responses API doesn't support 'tool' role | ||
| const cleanedMessages = messages.map((msg) => { | ||
| const { tool_calls: _, tool_call_id: __, ...cleanMsg } = msg; | ||
|
|
||
| // Transform tool role to user role for responses API compatibility | ||
| if (cleanMsg.role === "tool") { | ||
| return { | ||
| ...cleanMsg, | ||
| role: "user", | ||
| }; | ||
| } | ||
|
|
||
| return cleanMsg; | ||
| }); | ||
|
Contributor
There was a problem hiding this comment. 💡 Verification agent 🧩 Analysis chainOpenAI Responses: dropping tool_calls/tool_call_id and coercing 'tool' → 'user' likely breaks tool-result turns Removing tool_calls and tool_call_id and rewriting role "tool" to "user" loses the association between prior function calls and their results for reasoning models routed via the Responses API. The model will not see tool outputs, and follow-up assistant replies may be wrong. Please confirm the correct, current Responses API shape for passing prior tool calls and tool results. If Responses requires content items, map:
I can provide a concrete mapping once you confirm the expected payload. Would you like me to adjust this block to preserve tool context for Responses? 🌐 Web query: 💡 Result: Short answer: Use the assistant message with a "tool_calls" entry (id + function info) followed by a separate message with role:"tool", tool_call_id set to that id, and content set to the tool result. You do not send {"type":"tool_result",...} — the expected format is assistant.tool_calls then a role:"tool" message that references tool_call_id. See the official example. [1][2] Sources:
Preserve 🤖 Prompt for AI Agents |
||
|
|
||
| const responsesBody: any = { | ||
| model: usedModel, | ||
| input: cleanedMessages, | ||
| reasoning: { | ||
| effort: reasoning_effort || "medium", | ||
| summary: "detailed", | ||
|
|
@@ -593,11 +609,19 @@ export async function prepareRequestBody( | |
| if (tools && tools.length > 0) { | ||
| requestBody.tools = [ | ||
| { | ||
| functionDeclarations: tools.map((tool: any) => { | ||
| // Remove additionalProperties and $schema from parameters as Google doesn't accept them | ||
| const { | ||
| additionalProperties: _additionalProperties, | ||
| $schema: _$schema, | ||
| ...cleanParameters | ||
| } = tool.function.parameters || {}; | ||
| return { | ||
| name: tool.function.name, | ||
| description: tool.function.description, | ||
| parameters: cleanParameters, | ||
| }; | ||
| }), | ||
|
Comment on lines
+681
to
+693
Contributor
There was a problem hiding this comment. 🛠️ Refactor suggestion Sanitize tool parameter schemas deeply (nested Only top-level keys are stripped. Nested objects may still carry these fields, causing Google 400s. Consider a recursive prune before assigning Apply this refactor in the mapper: function stripMeta(o: unknown): unknown {
if (!o || typeof o !== "object") return o;
if (Array.isArray(o)) return o.map(stripMeta);
// shallow clone and recurse
const { additionalProperties, $schema, ...rest } = o as Record<string, unknown>;
for (const k of Object.keys(rest)) rest[k] = stripMeta(rest[k]);
return rest;
}Then: - const { additionalProperties: _additionalProperties, $schema: _$schema, ...cleanParameters } = tool.function.parameters || {};
+ const cleanParameters = stripMeta(tool.function.parameters || {});🤖 Prompt for AI Agents |
||
| }, | ||
| ]; | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Assert no residual tool_calls in final turn and log
Strengthen the test to ensure the assistant returned an actual answer (no further tool calls) and logs don’t record provider-emitted tool calls in this “with result” path.
Apply:
Would you like a streaming variant of this test for parity?
🤖 Prompt for AI Agents