Repository navigation
fix(actions): preserve none reasoning effort for ByteDance - #3381
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughByteDance is added to the providers that preserve ChangesByteDance reasoning effort
Estimated code review effort: 2 (Simple) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/actions/src/prepare-request-body.ts`:
- Line 1190: Update the native-provider explanation near the condition
containing usedProvider === "bytedance" to include ByteDance in the listed
providers treated as native none providers, keeping the comment aligned with the
normalization logic.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 50f771d8-eb92-4583-a1cb-ce50e16f8c5a
📒 Files selected for processing (2)
packages/actions/src/prepare-request-body.spec.tspackages/actions/src/prepare-request-body.ts
a78e0ee to
b3a67a7
Compare
b3a67a7 to
d7106cf
Compare
Summary
nnFixes #3365. ByteDance GLM-5.2 supports reasoning_effort none, but request-body normalization stripped it because ByteDance was missing from the native-none provider allowlist.nn- Preserve reasoning_effort none for ByteDance.n- Add a focused regression test.nn## Validationnn- prepare-request-body.spec.ts: 216 passedn- prepare-request-body.spec.ts + models.spec.ts: 267 passedn- Targeted Prettier and ESLint checks: passedn- turbo build for @llmgateway/actions: passed, 6 tasksnnNo provider API key or external service was required. Package-wide lint is blocked by pre-existing formatting failures in 30 unrelated files; the changed files pass targeted checks.Summary by CodeRabbit
reasoning_effort: "none"setting, ensuring it is correctly forwarded during processing.