Skip to content

fix(actions): preserve none reasoning effort for ByteDance - #3381

Merged
steebchen merged 2 commits into
theopenco:mainfrom
mikemikimike:fix/3365-bytedance-reasoning-none
Aug 3, 2026
Merged

steebchen merged 2 commits into
theopenco:mainfrom
mikemikimike:fix/3365-bytedance-reasoning-none

Conversation

@mikemikimike

@mikemikimike mikemikimike commented Aug 2, 2026 •

Copy link
Copy Markdown
Contributor

SummarynnFixes #3365. ByteDance GLM-5.2 supports reasoning_effort none, but request-body normalization stripped it because ByteDance was missing from the native-none provider allowlist.nn- Preserve reasoning_effort none for ByteDance.n- Add a focused regression test.nn## Validationnn- prepare-request-body.spec.ts: 216 passedn- prepare-request-body.spec.ts + models.spec.ts: 267 passedn- Targeted Prettier and ESLint checks: passedn- turbo build for @llmgateway/actions: passed, 6 tasksnnNo provider API key or external service was required. Package-wide lint is blocked by pre-existing formatting failures in 30 unrelated files; the changed files pass targeted checks.

Summary by CodeRabbit

  • Bug Fixes
    • ByteDance GLM-5.2 requests now preserve the reasoning_effort: "none" setting, ensuring it is correctly forwarded during processing.

@coderabbitai

coderabbitai Bot commented Aug 2, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4b6e3baf-71c3-4283-b8f8-73fe4ec59350

📥 Commits

Reviewing files that changed from the base of the PR and between a78e0ee and d7106cf.

📒 Files selected for processing (2)
  • packages/actions/src/prepare-request-body.spec.ts
  • packages/actions/src/prepare-request-body.ts
🚧 Files skipped from review as they are similar to previous changes (2)
  • packages/actions/src/prepare-request-body.spec.ts
  • packages/actions/src/prepare-request-body.ts

Walkthrough

ByteDance is added to the providers that preserve reasoning_effort: "none". A GLM-5.2 regression test verifies that request preparation forwards the value unchanged.

Changes

ByteDance reasoning effort

Layer / File(s) Summary
Enable and verify native none forwarding
packages/actions/src/prepare-request-body.ts, packages/actions/src/prepare-request-body.spec.ts
The provider allowlist and related documentation now include ByteDance. The GLM-5.2 test verifies that reasoning_effort: "none" remains in the generated request body.

Estimated code review effort: 2 (Simple) | ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes preserving "none" reasoning effort for ByteDance.
Linked Issues check ✅ Passed The changes add ByteDance to the native-"none" allowlist and test the required request-body behavior from issue #3365.
Out of Scope Changes check ✅ Passed The allowlist update and focused regression test directly support the linked issue without unrelated code changes.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/actions/src/prepare-request-body.ts`:
- Line 1190: Update the native-provider explanation near the condition
containing usedProvider === "bytedance" to include ByteDance in the listed
providers treated as native none providers, keeping the comment aligned with the
normalization logic.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 50f771d8-eb92-4583-a1cb-ce50e16f8c5a

📥 Commits

Reviewing files that changed from the base of the PR and between 3ab66a2 and 8e3cb9b.

📒 Files selected for processing (2)
  • packages/actions/src/prepare-request-body.spec.ts
  • packages/actions/src/prepare-request-body.ts

Comment thread packages/actions/src/prepare-request-body.ts
@steebchen
steebchen force-pushed the fix/3365-bytedance-reasoning-none branch from a78e0ee to b3a67a7 Compare August 3, 2026 16:41
@steebchen
steebchen enabled auto-merge August 3, 2026 17:18
@steebchen
steebchen force-pushed the fix/3365-bytedance-reasoning-none branch from b3a67a7 to d7106cf Compare August 3, 2026 18:18
@steebchen
steebchen added this pull request to the merge queue Aug 3, 2026
Merged via the queue into theopenco:main with commit 90a9b41 Aug 3, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants