fix(api): attribute purchase events to users

[smakosh]

PostHog payment conversion events (credits_purchased,
dev_plan_started, chat_plan_started, reset_pass_purchased) were all
captured against the literal distinct id "organization", piling every
purchase onto one pseudo-person. Capture them against the purchasing
user's id instead (the same id the frontends pass to
posthog.identify), resolved from checkout metadata or the org billing
email, so pageview journeys can be joined to payments in analytics.
Falls back to "organization" when no user can be resolved.

Co-Authored-By: Claude Fable 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01FZGskXGCobGxpJ6minAgpZ

Summary by CodeRabbit

• Analytics

  • Improved PostHog attribution for purchase/conversion events by using the purchaser’s user identity when available (instead of a generic fallback).
  • Included reset-pass purchases in payment/conversion tracking.

• Traffic Reports

  • Reports now show top pages by views.
  • Added “top converting pages” (attributed signups/payers using a lookback window).
  • Added blog post readership plus attributed signup/payer metrics.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 584a310d-e1f5-4f1f-aae7-78cdccc67aab

📥 Commits

Reviewing files that changed from the base of the PR and between 27d6172 and 6b57b36.

📒 Files selected for processing (2)

• apps/api/src/stripe.ts
• packages/scripts/src/traffic-report.ts

🚧 Files skipped from review as they are similar to previous changes (2)

• apps/api/src/stripe.ts
• packages/scripts/src/traffic-report.ts

---

Walkthrough

Stripe analytics now attribute purchase events to resolved purchaser IDs. Traffic reports now include top-page, conversion-attributed page, and blog conversion metrics in Discord embeds.

Changes

Stripe purchaser attribution

Layer / File(s)	Summary
Purchaser resolution and event attribution apps/api/src/stripe.ts	Purchase events resolve distinct IDs from purchaser emails or metadata, falling back to the organization identity.
Credit top-up attribution apps/api/src/stripe.ts	Credit top-up handlers pass resolved purchaser IDs into analytics events, with email-based fallback resolution.

Traffic conversion reporting

Layer / File(s)	Summary
Traffic report data contracts packages/scripts/src/traffic-report.ts	Adds typed page and conversion result fields, reset-pass payment events, and attribution configuration.
Page and conversion queries packages/scripts/src/traffic-report.ts	Queries and maps top pages, attributed converting pages, and blog conversion results using the configured lookback window.
Discord traffic report rendering packages/scripts/src/traffic-report.ts	Renders the new metrics as Discord tables with truncated paths and empty-state text.

Estimated code review effort: 4 (Complex) | ~45 minutes

Sequence Diagram(s)

sequenceDiagram
  participant fetchReport
  participant PostHogHogQL
  participant ReportData
  participant buildEmbed
  participant Discord
  fetchReport->>PostHogHogQL: Execute traffic and conversion queries
  PostHogHogQL-->>fetchReport: Return page and blog metrics
  fetchReport->>ReportData: Map query results
  ReportData->>buildEmbed: Provide report arrays
  buildEmbed->>Discord: Render traffic tables

Loading

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: attributing purchase events to users instead of organization IDs.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/weekly-traffic-report-metrics-fghv6y

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (3)

apps/api/src/stripe.ts (2)

1768-1792: 🚀 Performance & Scalability | 🔵 Trivial | 💤 Low value

Deduplicate emails to prevent redundant database queries.

If userEmail and organization.billingEmail happen to be identical, and no user exists for that email, this function will query the database twice for the exact same address. You can optimize this by deduplicating the list of emails before iterating.

♻️ Proposed refactor to deduplicate emails

 async function resolvePurchaserDistinctId(
 	...emails: (string | null | undefined)[]
 ): Promise<string> {
-	for (const email of emails) {
-		if (!email) {
-			continue;
-		}
+	const uniqueEmails = new Set<string>();
+	for (const email of emails) {
+		if (email) uniqueEmails.add(email);
+	}
+
+	for (const email of uniqueEmails) {
 		const purchaser = await db.query.user.findFirst({
 			where: { email: { eq: email } },
 		});

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@apps/api/src/stripe.ts` around lines 1768 - 1792, Update
resolvePurchaserDistinctId to deduplicate the provided email arguments before
querying db.query.user.findFirst, while preserving the existing null/undefined
filtering, purchaser-id return behavior, and "organization" fallback.

---

1411-1414: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Remove redundant type assertion.

The as string | undefined assertion is unnecessary because metadata?.userEmail is already correctly inferred as string | undefined from the Stripe.Metadata type.

• apps/api/src/stripe.ts#L1411-L1414: remove the as string | undefined cast from metadata?.userEmail.
• apps/api/src/stripe.ts#L1536-L1539: remove the as string | undefined cast from metadata?.userEmail.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@apps/api/src/stripe.ts` around lines 1411 - 1414, Remove the redundant
string-or-undefined type assertion from metadata?.userEmail in both
resolvePurchaserDistinctId call sites: apps/api/src/stripe.ts lines 1411-1414
and 1536-1539. Preserve the existing argument flow and rely on Stripe.Metadata’s
inferred type.

packages/scripts/src/traffic-report.ts (1)

357-370: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Consider reusing the shared host list instead of hardcoding 'llmgateway.io'.

Every other query filters by properties.$host IN (${HOST_LIST}), but blogConversionsQuery hardcodes e.properties.$host = 'llmgateway.io'. Not a bug today, but if the blog host constant already exists elsewhere (e.g. tied to PRODUCTS), referencing it here would keep the domain in one place.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/scripts/src/traffic-report.ts` around lines 357 - 370, The
blogConversionsQuery host filter currently hardcodes llmgateway.io; update it to
reuse the existing shared host list or blog host constant used by the other
traffic queries, preserving the existing pathname and aggregation behavior.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/scripts/src/traffic-report.ts`:
- Around line 83-96: Add "reset_pass_purchased" to the PAYMENT_EVENTS list so
convertingPages and blogConversions include reset-pass buyers; leave the
existing PAYMENT_EVENT_LIST generation unchanged.
- Around line 327-355: Bound attribution pageviews per person to
ATTRIBUTION_LOOKBACK_DAYS before that person’s first conversion, rather than
using the shared lookbackStart alone. Update the timestamp predicates in both
convertingPagesQuery and blogConversionsQuery to apply the corresponding
signed_up_at or paid_at lower bound while preserving the existing report-period
and conversion conditions.

---

Nitpick comments:
In `@apps/api/src/stripe.ts`:
- Around line 1768-1792: Update resolvePurchaserDistinctId to deduplicate the
provided email arguments before querying db.query.user.findFirst, while
preserving the existing null/undefined filtering, purchaser-id return behavior,
and "organization" fallback.
- Around line 1411-1414: Remove the redundant string-or-undefined type assertion
from metadata?.userEmail in both resolvePurchaserDistinctId call sites:
apps/api/src/stripe.ts lines 1411-1414 and 1536-1539. Preserve the existing
argument flow and rely on Stripe.Metadata’s inferred type.

In `@packages/scripts/src/traffic-report.ts`:
- Around line 357-370: The blogConversionsQuery host filter currently hardcodes
llmgateway.io; update it to reuse the existing shared host list or blog host
constant used by the other traffic queries, preserving the existing pathname and
aggregation behavior.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 2ff474d6-19eb-4be5-8f24-325657c4e291

📥 Commits

Reviewing files that changed from the base of the PR and between a31f188 and 27d6172.

📒 Files selected for processing (2)

• apps/api/src/stripe.ts
• packages/scripts/src/traffic-report.ts