Repository navigation
feat: add ByteDance AI terms - #2565
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughExtended provider definitions with an optional field for additional policy links. Added a ChangesAdditional Provider Links Feature
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1af6ff641d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| consumerTraining: null, | ||
| promptLogging: false, | ||
| retentionPeriod: "0 days", | ||
| retentionPeriod: "24 hours", |
There was a problem hiding this comment.
The ByteDance provider covers chat and image models as well as video models (for example seed-1-6-* and seedream-* in packages/models/src/models/bytedance.ts), and the UI renders this field generically as Retention: in the Data & Privacy card. The 24-hour wording in BytePlus docs applies to generated video asset/task URLs being deleted after 24 hours, not to provider-wide prompt/data retention, so this change misstates the privacy metadata for non-video ByteDance usage. Consider leaving the provider-level retention as 0 days/unknown or making the video asset lifetime model-specific.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Pull request overview
This PR extends the provider metadata model to support provider-specific policy links in the UI’s “Data & Privacy” card, and uses it to surface BytePlus service terms (“AI Terms”) for the ByteDance provider while updating its retention period display.
Changes:
- Added
additionalLinksprovider metadata for displaying extra policy/terms links in the UI. - Updated ByteDance data retention metadata from
0 daysto24 hours. - Rendered any provider
additionalLinksunder the Data & Privacy details in the provider hero component.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/models/src/providers.ts | Adds the additionalLinks provider metadata type/field and populates ByteDance’s extra “AI Terms” policy link; updates ByteDance retention. |
| apps/ui/src/components/providers/hero.tsx | Renders additionalLinks under the Data & Privacy card as external links. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| export interface ProviderAdditionalLink { | ||
| desc: string; | ||
| link: string; | ||
| } |
| {provider.additionalLinks.map((additionalLink) => ( | ||
| <a | ||
| key={additionalLink.link} | ||
| href={additionalLink.link} | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| className="inline-flex items-center gap-1 transition-colors hover:text-foreground" | ||
| > | ||
| {additionalLink.desc} | ||
| <ExternalLink className="h-3 w-3" /> | ||
| </a> | ||
| ))} |
| { | ||
| desc: "AI Terms", | ||
| link: "https://docs.byteplus.com/en/docs/legal/docs-service-specific-terms", | ||
| }, |
Summary
additionalLinksmetadata for provider-specific policy links in the Data & Privacy card.24 hoursand add the BytePlus Service Specific Terms link labeledAI Terms.Validation
pnpm formatpassed.pnpm buildpassed.pnpm test:unitfailed because the connected local Postgres test schema is stale: theusertable is missing theusernamecolumn expected by the current Drizzle schema. The suite reported 335 failures with errors likecolumn "username" of relation "user" does not exist/column "username" does not existacross DB-backed specs.Summary by CodeRabbit
New Features
Updates