feat(xai): add grok-4.3 model - #2133
Conversation
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughAdds a new XAI model definition ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
There was a problem hiding this comment.
Pull request overview
Adds the new grok-4-3 model definition to the xAI model catalog in packages/models, including capabilities (1M context, vision, reasoning, tools, JSON output, streaming) and tiered pricing metadata.
Changes:
- Add
xai/grok-4-3model entry with pricing tiers (<=200K vs >200K tokens). - Mark the model as streaming/vision/reasoning/tools/JSON-output capable.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| reasoning: true, | ||
| tools: true, | ||
| jsonOutput: true, | ||
| supportedParameters: xaiSupportedParamsNoFreqPresence, | ||
| }, |
There was a problem hiding this comment.
supportedParameters omits reasoning_effort, but prepareRequestBody only forwards reasoning_effort when the provider mapping’s supportedParameters is empty or explicitly includes it. As written, reasoning_effort will be silently dropped for this model (and any other model using xaiSupportedParamsNoFreqPresence). Add reasoning_effort to the supported parameter list for grok-4-3 (or to xaiSupportedParamsNoFreqPresence) so clients can control reasoning effort as intended.
Summary
grok-4.3to the xAI provider inpackages/modelsTest plan
TEST_MODELS="xai/grok-4-3" pnpm test:e2e— all 74 tests passpnpm format🤖 Generated with Claude Code
Summary by CodeRabbit