Skip to content

fix(gateway): handle network_error finish reason #1588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steebchen merged 1 commit into from
Feb 4, 2026
Merged

fix(gateway): handle network_error finish reason #1588

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions apps/gateway/src/lib/logs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@ export function getUnifiedFinishReason(
if (finishReason === "upstream_error") {
return UnifiedFinishReason.UPSTREAM_ERROR;
}
if (finishReason === "network_error") {
return UnifiedFinishReason.UPSTREAM_ERROR;
}
Comment on lines +50 to +52

Copilot AI Feb 4, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new network_error finish reason mapping should have test coverage. Looking at the test file (logs.spec.ts), similar error finish reasons like upstream_error, gateway_error, and client_error all have test coverage in the "handles special cases" test block. A test case should be added for network_error to maintain consistency with the existing test pattern.

Copilot uses AI. Check for mistakes.
if (finishReason === "client_error") {
return UnifiedFinishReason.CLIENT_ERROR;
}
Expand Down
Loading