Skip to content

fix(gateway): map google image safety finish reasons #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steebchen merged 1 commit into from
Dec 18, 2025
Merged

fix(gateway): map google image safety finish reasons #1340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions apps/gateway/src/lib/logs.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,18 @@ describe("getUnifiedFinishReason", () => {
expect(getUnifiedFinishReason("SPII", "google-ai-studio")).toBe(
UnifiedFinishReason.CONTENT_FILTER,
);
expect(getUnifiedFinishReason("LANGUAGE", "google-ai-studio")).toBe(
UnifiedFinishReason.CONTENT_FILTER,
);
expect(getUnifiedFinishReason("IMAGE_SAFETY", "google-ai-studio")).toBe(
UnifiedFinishReason.CONTENT_FILTER,
);
expect(
getUnifiedFinishReason("IMAGE_PROHIBITED_CONTENT", "google-ai-studio"),
).toBe(UnifiedFinishReason.CONTENT_FILTER);
expect(getUnifiedFinishReason("NO_IMAGE", "google-ai-studio")).toBe(
UnifiedFinishReason.CONTENT_FILTER,
);
Comment on lines +54 to +65

Copilot AI Dec 18, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new finish reason tests only cover the "google-ai-studio" provider, but the implementation in logs.ts applies these finish reasons to both "google-ai-studio" and "google-vertex" providers (lines 47-48 use a shared case statement). Test coverage should be added for the "google-vertex" provider to ensure these finish reasons work correctly for both Google provider types.

Copilot uses AI. Check for mistakes.
});

it("handles special cases", () => {
Expand Down
6 changes: 5 additions & 1 deletion apps/gateway/src/lib/logs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,11 @@ export function getUnifiedFinishReason(
finishReason === "PROHIBITED_CONTENT" ||
finishReason === "RECITATION" ||
finishReason === "BLOCKLIST" ||
finishReason === "SPII"
finishReason === "SPII" ||
finishReason === "LANGUAGE" ||
finishReason === "IMAGE_SAFETY" ||
finishReason === "IMAGE_PROHIBITED_CONTENT" ||
finishReason === "NO_IMAGE"
) {
return UnifiedFinishReason.CONTENT_FILTER;
}
Expand Down
Loading