Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[methods.partition DirectedSphereExclusion] #133

Open
3 tasks done
FarnazH opened this issue Jun 12, 2023 · 1 comment
Open
3 tasks done

[methods.partition DirectedSphereExclusion] #133

FarnazH opened this issue Jun 12, 2023 · 1 comment
Assignees

Comments

@FarnazH
Copy link
Member

FarnazH commented Jun 12, 2023

To do:

  • Add test to reach 100% coverage
  • Add comments in the code
  • Add formulas to docstring and polish docstring (add reference).
@FarnazH
Copy link
Member Author

FarnazH commented Jul 14, 2023

To be discussed in the next meeting:

  • The algorithm never attempts to select exactly the requested size subset. Review when selected is returned.
  • Add an argument so the user can specify whether they would like to optimize r, or just use r0 (guess) for selection.
  • random_seed argument is not used. Remove?
  • argument cluster_ids is not used! This needs to be fixed, but probably we need to change it across different methods.
  • The DirectedSphereExclusion is a distance-based method (similar to OptiSim); see the reference paper. So, it should be moved to methods.dissimilarity module (the name of this module should change to distance probably).

Based on the paper:

  1. We are not addressing ties when sorting the samples based on their distance to the reference. In the paper, it is recommended to use the closest point to reference to break the tie.
  2. This implementation only works for Minkowski p-norm measure, not any desired similarity measure.

FarnazH added a commit that referenced this issue Oct 27, 2023
The DirectedSphereExclusion is a distance-based method (similar to OptiSim).
So, it should be moved to methods.dissimilarity module. See #133
JackyZzZz pushed a commit to JackyZzZz/Selector that referenced this issue Jun 14, 2024
The DirectedSphereExclusion is a distance-based method (similar to OptiSim).
So, it should be moved to methods.dissimilarity module. See theochem#133
FanwangM pushed a commit that referenced this issue Jul 2, 2024
The DirectedSphereExclusion is a distance-based method (similar to OptiSim).
So, it should be moved to methods.dissimilarity module. See #133
@FarnazH FarnazH self-assigned this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants