feat : KBD component #969
Merged
feat : KBD component #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #969 +/- ##
==========================================
- Coverage 99.54% 93.52% -6.03%
==========================================
Files 163 182 +19
Lines 6621 7892 +1271
Branches 401 439 +38
==========================================
+ Hits 6591 7381 +790
- Misses 30 511 +481
☔ View full report in Codecov by Sentry. |
MateoWartelle
changed the title
|
I am going to write some tests and it should be ready for review after. I am open to change whatever is suggested. thanks |
|
@MateoWartelle please, do not use merge, use rebase instead. |
rluders
requested changes
Sep 21, 2023
rluders
requested changes
Sep 21, 2023
app/docs/components/kbd/kbd.mdx
Outdated
| <CodePreview | ||
| importFlowbiteReact="Kbd" | ||
| importExternal="import { MdKeyboardArrowLeft, MdKeyboardArrowRight, MdKeyboardArrowDown, MdKeyboardArrowUp } from 'react-icons/md';" | ||
| title="Arrow Keys Kbd" |
|
Looks nice, @MateoWartelle - just some small details that need to be fixed and we are good to get it merged. |
maman
pushed a commit
to transkripid/flowbite-react
that referenced
this pull request
Oct 7, 2023
* feat: kBD (Keyboard) component * feat: add kbd story (default, withIcon) * feat: remove extra sentence + flex wrap letter keys * docs: fix docs * feat: kbd basic tests, storybook withIcon + onlyIcon * docs: add missing importExternal for arrow keys docs * docs: review changes for documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize the changes made and the motivation behind them.
Kbd component to match existing flowbite library
Reference related issues using
#followed by the issue number.If there are breaking API changes - like adding or removing props, or changing the structure of the theme - describe them, and provide steps to update existing code.