-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(button): allow height of buttons stretch #906
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #906 +/- ##
==========================================
- Coverage 99.54% 93.52% -6.03%
==========================================
Files 163 182 +19
Lines 6621 7890 +1269
Branches 401 439 +38
==========================================
+ Hits 6591 7379 +788
- Misses 30 511 +481
☔ View full report in Codecov by Sentry. |
Thanks, @000000armor. I think that is worth to test what would happened if we have something like this: <Button.Group>
<Button color="gray">
<HiUserCircle className="mr-3 h-4 w-4" />
<p>
Profile
</p>
</Button>
<Button color="gray">
<HiAdjustments className="mr-3 h-4 w-4" />
<p>
Settings <br/> with breakline
</p>
</Button>
<Button color="gray">
<HiCloudDownload className="mr-3 h-4 w-4" />
<p>
Messages
</p>
</Button>
</Button.Group> I think that the icon and text will not be centered. Can you check? |
@rluders yes, I'll check it. that's a nice corner case. Maybe we should add it to storybook example to show how the component should behave in certain situations? |
@rluders is it expected behaviour for provided case? |
c639fe9
to
5016069
Compare
Sorry very late reply here, it got lost somehow. Yes, this would be the expected behavior. |
5016069
to
3fdbbf9
Compare
Summarize the changes made and the motivation behind them.
Add styles to parent container to allow children stretch
Reference related issues using
#
followed by the issue number.#855