Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): allow height of buttons stretch #906

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

000000armor
Copy link
Contributor

@000000armor 000000armor commented Aug 7, 2023

Summarize the changes made and the motivation behind them.

Add styles to parent container to allow children stretch

Reference related issues using # followed by the issue number.
#855

@vercel
Copy link

vercel bot commented Aug 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2023 1:00pm

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch coverage: 71.69% and project coverage change: -6.03% ⚠️

Comparison is base (7461173) 99.54% compared to head (3fdbbf9) 93.52%.
Report is 84 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #906      +/-   ##
==========================================
- Coverage   99.54%   93.52%   -6.03%     
==========================================
  Files         163      182      +19     
  Lines        6621     7890    +1269     
  Branches      401      439      +38     
==========================================
+ Hits         6591     7379     +788     
- Misses         30      511     +481     
Files Changed Coverage Δ
src/components/Pagination/helpers.ts 100.00% <ø> (ø)
src/components/Toast/theme.ts 100.00% <ø> (ø)
src/components/Datepicker/Datepicker.tsx 28.43% <28.43%> (ø)
src/components/Datepicker/Views/Days.tsx 36.00% <36.00%> (ø)
src/components/Datepicker/Views/Decades.tsx 37.70% <37.70%> (ø)
src/components/Datepicker/Views/Months.tsx 37.70% <37.70%> (ø)
src/components/Datepicker/Views/Years.tsx 37.70% <37.70%> (ø)
src/components/Banner/BannerCollapseButton.tsx 40.90% <40.90%> (ø)
src/components/Datepicker/helpers.ts 60.13% <60.13%> (ø)
src/components/Banner/Banner.tsx 64.70% <64.70%> (ø)
... and 45 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rluders
Copy link
Collaborator

rluders commented Aug 8, 2023

Thanks, @000000armor.

I think that is worth to test what would happened if we have something like this:

<Button.Group>
      <Button color="gray">
        <HiUserCircle className="mr-3 h-4 w-4" />
        <p>
          Profile
        </p>
      </Button>
      <Button color="gray">
        <HiAdjustments className="mr-3 h-4 w-4" />
        <p>
          Settings <br/> with breakline
        </p>
      </Button>
      <Button color="gray">
        <HiCloudDownload className="mr-3 h-4 w-4" />
        <p>
          Messages
        </p>
      </Button>
    </Button.Group>

I think that the icon and text will not be centered. Can you check?

@000000armor
Copy link
Contributor Author

@rluders yes, I'll check it. that's a nice corner case. Maybe we should add it to storybook example to show how the component should behave in certain situations?

@000000armor
Copy link
Contributor Author

Screenshot 2023-08-08 at 16 08 10 @rluders is it expected behaviour for provided case?

@rluders
Copy link
Collaborator

rluders commented Sep 21, 2023

Screenshot 2023-08-08 at 16 08 10 @rluders is it expected behaviour for provided case?

Sorry very late reply here, it got lost somehow. Yes, this would be the expected behavior.

@rluders rluders force-pushed the fix/button-group-height branch from 5016069 to 3fdbbf9 Compare September 22, 2023 12:56
@rluders rluders merged commit 10b54e3 into themesberg:main Sep 22, 2023
maman pushed a commit to transkripid/flowbite-react that referenced this pull request Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants