fix(select.tsx/badge.tsx): With icon classes preference #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the ordering of the classNames in the twMerge was removing important classes when Select hadan Icon fix themesberg#869
the ordering of the classNames in the twMerge was preventing yo customize padding attributes of the badge when it had an icon
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nigellima
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #877 +/- ##
==========================================
- Coverage 99.54% 99.53% -0.02%
==========================================
Files 163 166 +3
Lines 6621 6879 +258
Branches 401 418 +17
==========================================
+ Hits 6591 6847 +256
- Misses 30 32 +2
☔ View full report in Codecov by Sentry. |
rluders
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize the changes made and the motivation behind them.
twMergeis removing the padding classes for theSelect.tsxcomponent when an icon is passed.I also checked if the issue was happening in other components too and I noticed tha the
Badge.tsxcomponent had the same problem. Even though it was not breaking visually when a Badge had an icon, if the user passes ap-class to the custom theme object it was not being applied due to the preference ordering intwMergeReference related issues using
#followed by the issue number.Fix #869