-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(button.tsx): Relative Spinner size #868
Conversation
the Spinner component was not fitting inside the Button.tsx when isProcessing=true. Also a transition was added to the Button component to fit the Spinner. Fix themesberg#850
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #868 +/- ##
==========================================
- Coverage 99.54% 99.53% -0.02%
==========================================
Files 163 166 +3
Lines 6621 6879 +258
Branches 401 418 +17
==========================================
+ Hits 6591 6847 +256
- Misses 30 32 +2
☔ View full report in Codecov by Sentry. |
@rluders weird, the test in the CI / build workflow does not fail locally for me. |
https://github.com/themesberg/flowbite-react/actions/runs/5605163775/jobs/10253955428#step:8:342 I'm also not sure why exactly this is happening |
Could you re-run the workflow and see if the error persists? maybe it was some brittle failure |
I notice that some tests are failing, not 'cause the test subject is failing but because the test itself has some implementation issue... maybe some rendering, or delay process that is causing the issue. Probable we should create an issue to fix it, I'm sure that the problem isn't related to this PR specifically. |
Summarize the changes made and the motivation behind them.
This PR makes the component inside the component to be relative to the Button size when
isProcessing=true
. It also adds an width animation when the flag is toggled.Reference related issues using
#
followed by the issue number.Fix #850
If there are breaking API changes - like adding or removing props, or changing the structure of the theme - describe them, and provide steps to update existing code.