feat(toast.tsx): Stateless Toast #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when onDismiss is given to Toast.Toggle the component will not update ay of its inner states leaving the dismissal o dev's charge. It also removes the toast from the DOM when isRemoved is true BREAKING CHANGE: Removing "removed" theme support Fix themesberg#848
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #860 +/- ##
==========================================
- Coverage 99.54% 99.53% -0.02%
==========================================
Files 163 166 +3
Lines 6621 6858 +237
Branches 401 416 +15
==========================================
+ Hits 6591 6826 +235
- Misses 30 32 +2
☔ View full report in Codecov by Sentry. |
rluders
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize the changes made and the motivation behind them.
This PR adds the ability to convert the
Toastcomponent into a stateless mode by providingonDismisstoToast.Toggle.It also changes the default hiding behaviour. Now the Toast is removed from the DOM when
isRemoved = true. Finally, it adds by defaultrole="alert"to the toast rootReference related issues using
#followed by the issue number.Fix #848
If there are breaking API changes - like adding or removing props, or changing the structure of the theme - describe them, and provide steps to update existing code.
The theme property
root.removedhas been removed as it will not be needed anymore.