Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pagination theme file): added enabled attribute for pagination ba… #856

Merged

Conversation

kharbandaashu
Copy link
Contributor

@kharbandaashu kharbandaashu commented Jul 14, 2023

Tailwind css class attribute change. Hover class was getting applied even when button was disabled. so, added enabled: attribute to each hover class of pagination base theme. Now it will only show hover effect if button is enabled.

Fixes #849

No breaking changes.

@vercel
Copy link

vercel bot commented Jul 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2023 5:12pm

Copy link
Collaborator

@tulup-conner tulup-conner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but please edit your post by following the Pull Request template, which you can see here: https://github.com/themesberg/flowbite-react/blob/main/.github/PULL_REQUEST_TEMPLATE.md

@tulup-conner tulup-conner marked this pull request as draft July 14, 2023 07:40
@tulup-conner
Copy link
Collaborator

Convert this back to ready for review once you've done that and I'll merge this

@kharbandaashu kharbandaashu marked this pull request as ready for review July 14, 2023 13:04
@kharbandaashu
Copy link
Contributor Author

This looks good, but please edit your post by following the Pull Request template, which you can see here: https://github.com/themesberg/flowbite-react/blob/main/.github/PULL_REQUEST_TEMPLATE.md

Hey @tulup-conner , I changed the PR comments. This is the best I can do please let me know if it needs more improvement by sharing a sample PR.

…se theme

hover class was getting applied even when button is disabled. so, added enabled: attribute to each
hover class of pagination base theme. Now it will only show hover if button is enabled.

fix themesberg#849
@rluders rluders force-pushed the fix/disabled-hover-on-pagination branch from 531cf57 to cec7c0a Compare July 18, 2023 17:10
@rluders rluders merged commit ecc3f6e into themesberg:main Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pagination buttons still have hover styles when disabled
4 participants