fix(src/components/navbar): fix wrong type on <Navbar theme> #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You should only put the contents of `useTheme().theme.navbar.root` here, not
`useTheme().theme.navbar` as a whole. To migrate if you use `<Navbar theme={}`, remove `root: { ..
}` from your custom theme. If you customized child components here, you'll need to move those
changes to each child's `theme={}` attribute.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tulup-conner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
You should only put the contents of
useTheme().theme.navbar.roothere, notuseTheme().theme.navbaras a whole. To migrate if you use<Navbar theme={}, removeroot: { .. }from your custom theme. If you customized child components here, you'll need to move thosechanges to each child's
theme={}attribute.Type of change
Please delete options that are not relevant.
Breaking changes
TODO
How Has This Been Tested?
Checklist: