Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: life quality improvements #825

Merged
merged 5 commits into from
Jun 28, 2023

Conversation

rluders
Copy link
Collaborator

@rluders rluders commented Jun 25, 2023

Description

This PR adds a few changes, most of them related to my usage experience.

  • Adds iconLight and iconDark as optional props to DarkThemeToggle component;
  • Fixes the theme component props for Navbar component;
  • Adds access to the listItem element to the SidebarItem theme;
  • Excludes lib/**/* from vitest, it seems that only excluding lib in this case wasn't actually working well...

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Breaking changes

Navbar component now access the correct theme interface, and it could break any customization for this component. The new format is visible in the documentation.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Existing unit tests still working
  • Local testing (a separated project that uses flowbite-react)

Test Configuration:

Not relevant.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@vercel
Copy link

vercel bot commented Jun 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2023 7:09pm

@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (7461173) 99.54% compared to head (1fc1e29) 99.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #825   +/-   ##
=======================================
  Coverage   99.54%   99.54%           
=======================================
  Files         163      163           
  Lines        6621     6628    +7     
  Branches      401      404    +3     
=======================================
+ Hits         6591     6598    +7     
  Misses         30       30           
Impacted Files Coverage Δ
src/components/DarkThemeToggle/DarkThemeToggle.tsx 100.00% <100.00%> (ø)
src/components/Navbar/Navbar.tsx 100.00% <100.00%> (ø)
src/components/Navbar/NavbarToggle.tsx 100.00% <100.00%> (ø)
src/components/Sidebar/SidebarItem.tsx 100.00% <100.00%> (ø)
src/components/Sidebar/theme.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rluders rluders marked this pull request as ready for review June 25, 2023 18:48
@rluders
Copy link
Collaborator Author

rluders commented Jun 25, 2023

I just need to fix one thing for the docs, that I notice when Vercel tried to deploy it. DONE

@rluders rluders force-pushed the feat/self-experience-improvement branch from ad728c7 to 6a933b3 Compare June 25, 2023 19:02
@rluders rluders requested a review from tulup-conner June 25, 2023 19:02
@rluders rluders force-pushed the feat/self-experience-improvement branch from 6a933b3 to 1fc1e29 Compare June 25, 2023 19:03
@rluders
Copy link
Collaborator Author

rluders commented Jun 28, 2023

I need these changes ASAP, so... I'm getting it merged arbitrarily.

@rluders rluders merged commit 2de9c14 into themesberg:main Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant