-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: life quality improvements #825
feat: life quality improvements #825
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #825 +/- ##
=======================================
Coverage 99.54% 99.54%
=======================================
Files 163 163
Lines 6621 6628 +7
Branches 401 404 +3
=======================================
+ Hits 6591 6598 +7
Misses 30 30
☔ View full report in Codecov by Sentry. |
|
ad728c7
to
6a933b3
Compare
6a933b3
to
1fc1e29
Compare
I need these changes ASAP, so... I'm getting it merged arbitrarily. |
Description
This PR adds a few changes, most of them related to my usage experience.
iconLight
andiconDark
as optional props toDarkThemeToggle
component;theme
component props forNavbar
component;listItem
element to theSidebarItem
theme;lib/**/*
fromvitest
, it seems that only excludinglib
in this case wasn't actually working well...Fixes # (issue)
Type of change
Please delete options that are not relevant.
Breaking changes
Navbar
component now access the correct theme interface, and it could break any customization for this component. The new format is visible in the documentation.How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Not relevant.
Checklist: