-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add Tables of Contents to every page #806
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -0,0 +1,16 @@ | |||
'use client'; |
Check warning
Code scanning / CodeQL
Unknown directive
@@ -0,0 +1,16 @@ | |||
'use client'; |
Check warning
Code scanning / CodeQL
Unknown directive
@@ -0,0 +1,16 @@ | |||
'use client'; |
Check warning
Code scanning / CodeQL
Unknown directive
@@ -0,0 +1,17 @@ | |||
'use client'; |
Check warning
Code scanning / CodeQL
Unknown directive
@@ -0,0 +1,16 @@ | |||
'use client'; |
Check warning
Code scanning / CodeQL
Unknown directive
@@ -0,0 +1,16 @@ | |||
'use client'; |
Check warning
Code scanning / CodeQL
Unknown directive
@@ -0,0 +1,17 @@ | |||
'use client'; |
Check warning
Code scanning / CodeQL
Unknown directive
@@ -0,0 +1,16 @@ | |||
'use client'; |
Check warning
Code scanning / CodeQL
Unknown directive
Hey @tulup-conner, Works great, but there are some things:
The first thing that I've mentioned definitely needs to be done for this PR to be merged and we should basically remove it from the center area and move it to the right side where you have the styles/positioning. Cheers, |
@zoltanszogyenyi We've already discussed this but for posterity - we'll be using this PR to make some systemic changes to how we load MDX so we can process the MDX on the server and then spit the headings out in a sidebar, which is pretty much impossible with how we are currently rendering MDX. Once those changes are made I'll follow up here with the Tables of Contents moved into the correct locations. |
89e63ad
to
0380f85
Compare
0380f85
to
8e36b34
Compare
I haven't been able to transition us to loading MDX on the server, but we still have Tables of Contents, they are just client-rendered, unfortunately. A few blockers:
|
We will want to refine the way we do this soon. Ideally, this would be solved by serializing the MDX on the server and sending the Table of Contents as data to the client.
8e36b34
to
6123bf6
Compare
Description
TODO
Adds Tables of Contents to the top of every page in the documentation. We will change the position of the Table of Contents later, to match flowbite.com, where it is a sidebar on the right-hand side of the screen, but that will require some more involved backend work.
Also adds a Theme section to each component's docs, which include the TypeScript typing of that component's available
theme={}
customization options. We can and should take in feedback on how useful this actually is, and look for opportunities to make it as useful as possible. Generally speaking, dumping TypeScript types isn't necessarily that helpful, but it's better than having no guidance at all (the current state).Type of change
Breaking changes
None.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: