fix: pagination button not being highlighted correctly #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IuriPires
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #725 +/- ##
=======================================
Coverage 99.43% 99.43%
=======================================
Files 131 131
Lines 6559 6559
Branches 493 493
=======================================
Hits 6522 6522
Misses 37 37
☔ View full report in Codecov by Sentry. |
IuriPires
changed the title
|
Hey @rluders could you check this one, please? :D |
rluders
requested changes
May 12, 2023
rluders
approved these changes
May 25, 2023
rtraficante
pushed a commit
to rtraficante/flowbite-react
that referenced
this pull request
May 26, 2023
* fix: removed unnecessary tailwind class * fix: bg-blue-50 and dark:bg-gray-700 important --------- Co-authored-by: Ricardo Lüders <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
A unnecessary Tailwind class was being used causing the PaginationButton to not highlight itself correctly when active.
Fixes #719
Type of change
Please delete options that are not relevant.
Breaking changes
Please document the breaking changes if suitable.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
For testing this fix, I ran Storybook locally to make sure the fix would be enough. Now the current page selected button is being highlighted correctly both on light and dark mode.
Test Configuration:
Checklist: