-
-
Notifications
You must be signed in to change notification settings - Fork 446
fix(components/accordion): allow opened panel to be closed #684 - add accordion tests #705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(components/accordion): allow opened panel to be closed #684 - add accordion tests #705
Conversation
… after being opened Accordion content can now be closed and opened leaving all items collapsed. themesberg#618
Quick merge for local
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to run the npm run prettier:fix
before commit. :)
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #705 +/- ##
=======================================
Coverage 99.43% 99.43%
=======================================
Files 131 131
Lines 6495 6502 +7
Branches 488 488
=======================================
+ Hits 6458 6465 +7
Misses 37 37
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @mufasubhai
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # 618
Type of change
Please delete options that are not relevant.
Breaking changes
Please document the breaking changes if suitable.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: