Skip to content

feat(/lib/theme): add Tailwind CSS colors to <Badge>s #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 22, 2023

Conversation

brenoliradev
Copy link
Contributor

Description

This change starts adding all colors to components in Flowbite. I'll be partially updating the components until I got every of then with all colors from FlowbiteColors avaliable.

Fixes # 473 (partially)

Type of change

  • New feature

How Has This Been Tested?

Since it was a visual change I used the Storybook to validate if colors are changing as expected.

  • Storybook

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Base: 99.31% // Head: 99.31% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (6bbaac9) compared to base (3f115c6).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #617   +/-   ##
=======================================
  Coverage   99.31%   99.31%           
=======================================
  Files         131      131           
  Lines        6412     6419    +7     
  Branches      477      477           
=======================================
+ Hits         6368     6375    +7     
  Misses         44       44           
Impacted Files Coverage Δ
src/lib/components/Badge/Badge.tsx 100.00% <100.00%> (ø)
src/lib/theme/default.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rluders rluders merged commit f00628f into themesberg:main Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants