Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sytles(button): support for all colors in button #598

Merged

Conversation

brenoliradev
Copy link
Contributor

Description

This continues adding all of FlowbiteColors to components as PR #586.

Fixes # 473 (partially)

Type of change

  • New feature

How Has This Been Tested?

Since it was a visual change I used the Storybook to validate if colors are changing as expected.

  • Storybook

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@720c8ef). Click here to learn what that means.
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #598   +/-   ##
=======================================
  Coverage        ?   99.35%           
=======================================
  Files           ?      131           
  Lines           ?     6390           
  Branches        ?      480           
=======================================
  Hits            ?     6349           
  Misses          ?       41           
  Partials        ?        0           
Impacted Files Coverage Δ
src/lib/components/Button/Button.tsx 100.00% <100.00%> (ø)
src/lib/theme/default.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

tulup-conner
tulup-conner previously approved these changes Feb 21, 2023
Copy link
Collaborator

@tulup-conner tulup-conner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@tulup-conner tulup-conner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tulup-conner tulup-conner merged commit e88cdab into themesberg:main Feb 21, 2023
@tulup-conner tulup-conner added this to the 0.4.0 milestone Feb 21, 2023
@tulup-conner tulup-conner added the 🚀 enhancement New feature or request label Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants