refactor(component): simplify the usage of spinner inside the Button

[aminlotfi]

re #175

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change contains a documentation update

Breaking changes

Please document the breaking changes if suitable.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Test A
• Test B

Test Configuration:

• Firmware version:
• Hardware:
• Toolchain:
• SDK:

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented on my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• I have checked my code and corrected any misspellings

[codecov]

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ff52bb4) 99.42% compared to head (9de45d4) 99.43%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #535   +/-   ##
=======================================
  Coverage   99.42%   99.43%           
=======================================
  Files         130      131    +1     
  Lines        6480     6495   +15     
  Branches      485      488    +3     
=======================================
+ Hits         6443     6458   +15     
  Misses         37       37           

Impacted Files	Coverage Δ
src/lib/components/Button/Button.tsx	100.00% <100.00%> (ø)
src/lib/theme/default.ts	100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[tulup-conner]

@aminlotfi Are you still able to finish this? Would be happy to add this to 1.0.0

[rluders]

It isn't perfect but should be fine.

[tulup-conner]

It may not be a bad idea to add a variant of button that is typed specifically to contain a spinner to move some of the code added here out of the way of the standard button. The component is rather large now.

[rluders]

@tulup-conner or maybe just split the button into sub-components to make it easier to understand?