Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Valine available #926

Merged
merged 1 commit into from
Jun 24, 2019
Merged

Make Valine available #926

merged 1 commit into from
Jun 24, 2019

Conversation

sli1989
Copy link
Collaborator

@sli1989 sli1989 commented Jun 24, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: #922

What is the new behavior?

With the Fix of unreachable issue with LeanCloud service in Valine, the new Valine will automatically introduce av-min.js.
So delete the section of av-min.js in Valine

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@CLAassistant
Copy link

CLAassistant commented Jun 24, 2019

CLA assistant check
All committers have signed the CLA.

@sli1989
Copy link
Collaborator Author

sli1989 commented Jun 24, 2019

@xCss Need your review, thanks.

Copy link
Contributor

@xCss xCss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it can be modified to be configurable here.

layout/_third-party/comments/valine.swig Show resolved Hide resolved
@sli1989 sli1989 merged commit 7eaf354 into theme-next:master Jun 24, 2019
@1v9 1v9 added this to the v7.2.0 milestone Jun 24, 2019
@stevenjoezhang
Copy link
Contributor

hexo-theme-next/_config.yml

Lines 1161 to 1166 in 7eaf354

# leancloud-storage
# See: https://www.npmjs.com/package/leancloud-storage
# Example:
# leancloud: //cdn.jsdelivr.net/npm/leancloud-storage@3/dist/av-min.js
leancloud:

@1v9 1v9 mentioned this pull request Jun 24, 2019
@1v9 1v9 changed the title Update LeanCloud issue in Valine Make Valine available Jun 29, 2019
@sli1989 sli1989 deleted the valine branch July 2, 2019 00:59
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Valine is not available because of changing of the leancloud.cn's domain
5 participants