Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade the internal jQuery to v3.4.1 #903

Merged
merged 1 commit into from
Jun 11, 2019
Merged

Upgrade the internal jQuery to v3.4.1 #903

merged 1 commit into from
Jun 11, 2019

Conversation

1v9
Copy link
Member

@1v9 1v9 commented Jun 8, 2019 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Core dependency update.

What is the current behavior?

Issue resolved: #886

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@Raincal Raincal marked this pull request as ready for review June 8, 2019 11:02
@1v9 1v9 added this to the v7.2.0 milestone Jun 8, 2019
@weekly-digest weekly-digest bot mentioned this pull request Jun 9, 2019
Closed
@1v9 1v9 merged commit a0136c2 into master Jun 11, 2019
@delete-merged-branch delete-merged-branch bot deleted the jQuery branch June 11, 2019 00:27
@weekly-digest weekly-digest bot mentioned this pull request Jun 16, 2019
Closed
@stevenjoezhang stevenjoezhang mentioned this pull request Jul 30, 2019
Closed
11 tasks
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
@1v9
Upgrade the internal jQuery to v3.4.1 (theme-next#903)
1f9748c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenjoezhang stevenjoezhang stevenjoezhang approved these changes

@ivan-nginx ivan-nginx Awaiting requested review from ivan-nginx

@maple3142 maple3142 Awaiting requested review from maple3142

@sli1989 sli1989 Awaiting requested review from sli1989

Assignees
No one assigned
Labels
🔌 3rd Party Plugin
Projects
None yet
Milestone
v7.2.0
Development

Successfully merging this pull request may close these issues.

Should we upgrade jQuery to 3.4.1 because of known security vulnerabilities?
2 participants
@1v9 @stevenjoezhang